[GPU] Add allowed order for 3d transpose fusion in transformation #30873
+116
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {3, 0, 1, 2} | ||
| }; | ||
|
|
||
| static const std::vector<std::vector<size_t>> allowed_orders_3d = { |
There was a problem hiding this comment.
Why does it have a 4-dimensional order instead of a 3-dimensional order, even though it is a 3D checking order?
There was a problem hiding this comment.
@ahnyoung-paul The 3D order is converted to 4D in onednn side
. So I use 4D order.
There was a problem hiding this comment.
nit: hmm maybe there is someway to create common list for 3d and 4d orders to avoid comparison by future reader(programmer) of this code or at least maybe add what these lists differ(0, 3, 1, 2) at end of allowed_orders_4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: