[cpu][gpu][ref]: OneHot op: Added support for handling negative indices in onnx.OneHot-11 fashion. #31539

pkowalc1 · 2025-07-31T09:42:08Z

OneHot specification is extended with new attribute: negative_indices_mode, with two modes:

ignore_negative, which is exactly the way OneHot operator was working so far
normalize, which is aimed to support onnx.OneHot-11 op.

Added support of this new extension to reference, CPU and GPU implementations. Added new tests.

Tickets:

CVS-73538

…ests.

…owalc1/openvino into fix_one_hot_negative_indicies

Lyamin-Roman

LGTM for GPU part

mitruska

The changes in OneHot operation are backward compatible, and maintain original behavior by default. It should be acceptable to make it within the same op version with proper note in the spec, as it has been proposed. Such approach requires less changes in the code base, in fact mitigate regressions risk and reduce multi version op maintenance.

*Added suggestion for better tests coverage of the changes.

mitruska · 2025-08-13T12:52:41Z

src/core/reference/include/openvino/reference/one_hot.hpp

@@ -16,7 +17,9 @@ void one_hot(const INPUT_TYPE* indices,
             const size_t depth,
             const int64_t one_hot_axis,
             const char* on_value,
-             const char* off_value) {
+             const char* off_value,
+             const op::v1::OneHot::NegativeIndicesMode mode) {


Optional: The reference could have a default (backward compatible) mode as well.

Can this model be something not depends on OP version? if there will be new version OneHot the v1 mode maybe not used and usually references can be shared or expanded for new versions

mitruska · 2025-08-13T12:53:38Z

src/core/include/openvino/op/one_hot.hpp

+    /// \brief Sets the negative indices mode.
+    void set_negative_indices_mode(NegativeIndicesMode mode) {
+        m_negative_indices_mode = mode;
+    }
+    /// \return The negative indices mode.
+    NegativeIndicesMode get_negative_indices_mode() const {
+        return m_negative_indices_mode;
+    }
+


Usually it is recommended by @praasz to have set/get body in .cpp

mitruska · 2025-08-13T12:56:58Z

src/core/reference/include/openvino/reference/one_hot.hpp

-                size_t output_offset = out_elem_size * (outer_i * depth + inner_i + oh_index * inner_block);
+            const int64_t input_val = static_cast<int64_t>(indices[outer_i + inner_i]);
+            const int64_t depth_i64 = static_cast<int64_t>(depth);
+            const int64_t actual_index = (input_val < 0 && is_mode_normalize) ? depth_i64 + input_val : input_val;


I can see there is onnx test enabled, but any changes in the reference implementation should be covered by the corresponding "Template plugin" tests and expected output:

openvino/src/plugins/template/tests/functional/op_reference/one_hot.cpp

Line 41 in 4c938b0

class ReferenceOneHotTest : public testing::TestWithParam<OneHotParams>, public CommonReferenceTest {

mitruska · 2025-08-13T12:58:22Z

src/core/src/op/one_hot.cpp

@@ -85,13 +89,19 @@ void OneHot::validate_and_infer_types() {
 bool OneHot::visit_attributes(AttributeVisitor& visitor) {
    OV_OP_SCOPE(v1_OneHot_visit_attributes);
    visitor.on_attribute("axis", m_axis);
+    visitor.on_attribute("negative_indices_mode", m_negative_indices_mode);


The new attribute should be covered by the corresponding "visitor" tests:

openvino/src/core/tests/visitors/op/one_hot.cpp

Line 29 in 4c938b0

EXPECT_EQ(g_one_hot->get_axis(), one_hot->get_axis());

mitruska · 2025-08-13T13:00:58Z

src/frontends/onnx/tests/models/one_hot_no_axis.prototxt

@@ -72,5 +72,5 @@ graph {
  }
 }
 opset_import {
-  version: 9
+  version: 11


In fact, there should be a new test model file added with version 11, and the old one should be kept for the tests of the older version.

mitruska · 2025-08-13T13:06:31Z

src/frontends/onnx/tests/onnx_import.in.cpp

+OPENVINO_TEST(${BACKEND_NAME}, onnx_model_one_hot_without_axis_negative_indicies) {
+    auto model = convert_model("one_hot_no_axis.onnx");
+
+    std::vector<std::vector<std::int64_t>> inputs{{0, -5, -4}, {2, 5}};


Could you please add a test where on/off_value is a Constant? It's current limitation of CPU OneHot implementation:

openvino/src/plugins/intel_cpu/src/nodes/one_hot.cpp

Lines 40 to 48 in adcb532

if (ov::as_type_ptr<const ov::op::v0::Constant>(oneHot->get_input_node_shared_ptr(ON_VALUE_ID)) == nullptr) {

errorMessage = "Only const 'on_value' input is supported";

return false;

}

if (ov::as_type_ptr<const ov::op::v0::Constant>(oneHot->get_input_node_shared_ptr(OFF_VALUEAXES_ID)) ==

nullptr) {

errorMessage = "Only const 'off_value' input is supported";

return false;

}

mitruska · 2025-08-13T13:11:03Z

src/plugins/intel_cpu/tests/functional/custom/single_layer_tests/one_hot.cpp

@@ -174,6 +189,7 @@ const std::vector<ov::Shape> staticInputShapes0D = {
 const auto testCase_1d = ::testing::Combine(
        ::testing::ValuesIn(static_shapes_to_test_representation(staticInputShapes0D)),
        ::testing::Values(-1, 0),
+        ::testing::Values(OHMode::IGNORE_NEGATIVE, OHMode::NORMALIZE),


Great that the CPU tests has been extended, as those single_layer_tests use reference implementation for comparison, the missing part is to ensure correctness of the output values is to update the reference implementation tests.

mitruska · 2025-08-13T13:19:36Z

src/frontends/onnx/tests/runtime/ie/unit_test.manifest

@@ -90,6 +90,7 @@ onnx_model_conv_with_dynamic_batch
 # OneHot operation has a form that is not supported
 onnx_model_one_hot_without_axis
 onnx_model_one_hot_with_axis
+onnx_model_one_hot_without_axis_negative_indicies


The tests listed here are skipped for CPU/GPU plugin validation. The Template/interpreter plugin (reference) has a separate manifest file here https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/onnx/tests/runtime/interpreter/unit_test.manifest
what means it is still tested with reference.
My suggestion is to create additional case to fit the plugin expectations, likely with on/off_value as a Constant input.

olpipi · 2025-08-21T08:56:45Z

src/core/include/openvino/op/one_hot.hpp

+std::ostream& operator<<(std::ostream& s, const op::v1::OneHot::NegativeIndicesMode& mode);
+
+template <>
+class OPENVINO_API AttributeAdapter<op::v1::OneHot::NegativeIndicesMode>


Please try to add appropriate extern template to openvino/src/core/include/openvino/core/attribute_adapter.hpp:265

It helps to speed up build

[ref][one_hot]: Added support for negative indicies. Fixed tests.

597c1e3

pkowalc1 requested a review from a team as a code owner July 31, 2025 09:42

pkowalc1 added the WIP work in progress label Jul 31, 2025

pkowalc1 requested a review from a team as a code owner July 31, 2025 09:42

github-actions bot added category: Core OpenVINO Core (aka ngraph) category: ONNX FE OpenVINO ONNX FrontEnd labels Jul 31, 2025

pkowalc1 added 3 commits July 31, 2025 09:47

[ref][one_hot]: Fixed code style.

04e718e

[onnx]: Disabled onehot test.

972560b

[gpu][one_hot]: Added support for negative indicies, added unittests.

7304114

pkowalc1 requested review from a team as code owners August 1, 2025 09:57

github-actions bot added the category: GPU OpenVINO GPU plugin label Aug 1, 2025

[cpu]: [one_hot]: Added support for negative indicies and and added t…

2f937d5

…ests.

pkowalc1 requested review from a team as code owners August 4, 2025 09:15

github-actions bot added the category: CPU OpenVINO CPU plugin label Aug 4, 2025

[doc]:[one_hot]: Added info about supporting negative indicies.

deb076b

pkowalc1 requested a review from a team as a code owner August 4, 2025 09:24

pkowalc1 requested review from akopytko and removed request for a team August 4, 2025 09:24

github-actions bot added the category: docs OpenVINO documentation label Aug 4, 2025

pkowalc1 changed the title ~~[WIP][ref][one_hot]: Added support for negative indicies. Fixed tests.~~ [WIP][cpu][gpu][ref]: OneHot op: Added support for negative indices. Fixed tests. Aug 4, 2025

pkowalc1 changed the title ~~[WIP][cpu][gpu][ref]: OneHot op: Added support for negative indices. Fixed tests.~~ [WIP][cpu][gpu][ref]: OneHot op: Added support for negative indices. Added tests. Aug 4, 2025

pkowalc1 added 2 commits August 4, 2025 14:15

Merge branch 'master' into fix_one_hot_negative_indicies

5e61894

[TEMP][CI]: Add printing input to failing tests.

0ea1888

pkowalc1 requested review from a team as code owners August 5, 2025 07:32

github-actions bot added the no-match-files label Aug 5, 2025

[ref]: Added NegativeIndicesMode to OneHot. Fixed ref and onnx tests.

b76c367

github-actions bot added the category: CPP API OpenVINO CPP API bindings label Aug 7, 2025

pkowalc1 added 5 commits August 7, 2025 14:30

[onnx]: Fixed doc check.

33459d7

[one_hot]: Fixed code style.

c0c8d45

[cpu][onehot]: Added support for oh mode. Fixed tests.

2d6e42c

[gpu][one_hot]: Added support for indicies mode with tests.

f8ce920

Fixed clang-format.

fd4c4d8

pkowalc1 changed the title ~~[WIP][cpu][gpu][ref]: OneHot op: Added support for negative indices. Added tests.~~ [WIP][cpu][gpu][ref]: OneHot op: Added support for negative indices. Added tests mode. Aug 8, 2025

pkowalc1 added 3 commits August 8, 2025 13:51

Merge branch 'master' into fix_one_hot_negative_indicies

77fffc3

[doc][onehot]: Added description of negative indices mode.

889ed07

Merge branch 'fix_one_hot_negative_indicies' of https://github.com/pk…

3ff9d3d

…owalc1/openvino into fix_one_hot_negative_indicies

pkowalc1 changed the title ~~[WIP][cpu][gpu][ref]: OneHot op: Added support for negative indices. Added tests mode.~~ [WIP][cpu][gpu][ref]: OneHot op: Added new mode to support for negative indices. Aug 12, 2025

pkowalc1 changed the title ~~[WIP][cpu][gpu][ref]: OneHot op: Added new mode to support for negative indices.~~ [cpu][gpu][ref]: OneHot op: Added new mode to support for negative indices. Aug 12, 2025

pkowalc1 changed the title ~~[cpu][gpu][ref]: OneHot op: Added new mode to support for negative indices.~~ [cpu][gpu][ref]: OneHot op: Added support for handling negative indices in onnx.OneHot-11 fashion. Aug 12, 2025

pkowalc1 removed the WIP work in progress label Aug 12, 2025

Lyamin-Roman approved these changes Aug 12, 2025

View reviewed changes

PiotrKrzem approved these changes Aug 12, 2025

View reviewed changes

mitruska linked an issue Aug 13, 2025 that may be closed by this pull request

[Bug]: wrong shape of results produced by OneHot operator #31120

Open

3 tasks

mitruska approved these changes Aug 13, 2025

View reviewed changes

mitruska assigned pkowalc1 Aug 13, 2025

olpipi reviewed Aug 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[cpu][gpu][ref]: OneHot op: Added support for handling negative indices in onnx.OneHot-11 fashion. #31539

[cpu][gpu][ref]: OneHot op: Added support for handling negative indices in onnx.OneHot-11 fashion. #31539

Uh oh!

pkowalc1 commented Jul 31, 2025 •

edited

Loading

Uh oh!

Lyamin-Roman left a comment

Uh oh!

mitruska left a comment

Uh oh!

mitruska Aug 13, 2025

Uh oh!

praasz Aug 21, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

mitruska Aug 13, 2025

Uh oh!

olpipi Aug 21, 2025

Uh oh!

Uh oh!

	if (ov::as_type_ptr<const ov::op::v0::Constant>(oneHot->get_input_node_shared_ptr(ON_VALUE_ID)) == nullptr) {
	errorMessage = "Only const 'on_value' input is supported";
	return false;
	}
	if (ov::as_type_ptr<const ov::op::v0::Constant>(oneHot->get_input_node_shared_ptr(OFF_VALUEAXES_ID)) ==
	nullptr) {
	errorMessage = "Only const 'off_value' input is supported";
	return false;
	}

[cpu][gpu][ref]: OneHot op: Added support for handling negative indices in onnx.OneHot-11 fashion. #31539

Are you sure you want to change the base?

[cpu][gpu][ref]: OneHot op: Added support for handling negative indices in onnx.OneHot-11 fashion. #31539

Uh oh!

Conversation

pkowalc1 commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tickets:

Uh oh!

Lyamin-Roman left a comment

Choose a reason for hiding this comment

Uh oh!

mitruska left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkowalc1 commented Jul 31, 2025 •

edited

Loading