[core] Make the internal implementation of Core.compile_model(fs::path) the base implementation #33740

almilosz · 2026-01-21T16:25:59Z

Details:

Places where I stopped

openvino/src/inference/src/dev/plugin.cpp

Line 59 in 626f1c6

OV_PLUGIN_CALL_STATEMENT(return {m_ptr->compile_model(ov::util::path_to_string(model_path), properties), m_so});

openvino/src/inference/src/dev/core_impl.cpp

Line 1731 in 626f1c6

return ov::util::read_model(ov::util::make_path(modelPath),

Tickets:

CVS-178326

src/inference/src/cpp/core.cpp

praasz · 2026-01-23T06:11:45Z

src/inference/include/openvino/runtime/core.hpp

    CompiledModel compile_model(const std::string& model_path, const AnyMap& properties = {});

-    template <class Path, std::enable_if_t<std::is_same_v<Path, std::filesystem::path>>* = nullptr>
-    auto compile_model(const Path& model_path, const AnyMap& properties = {}) const {


Instead remove it make if constexpr for string or wstring to call correct resolve overload use

src/inference/src/cpp/core.cpp

praasz · 2026-01-23T06:13:58Z

src/inference/include/openvino/runtime/core.hpp

                                const std::string& device_name,
                                const AnyMap& properties = {});
+
+    template <class Path, std::enable_if_t<std::is_constructible_v<std::wstring, Path>>* = nullptr>


Is possible to remove this enable_if and resolve it by single template compile_model(const Path& model_path,

…into almilosz/compile_model_path

This reverts commit 31f50f5.

src/inference/dev_api/openvino/runtime/icore.hpp

praasz · 2026-02-03T12:31:47Z

src/inference/include/openvino/runtime/core.hpp

-    CompiledModel compile_model(const std::wstring& model_path, const AnyMap& properties = {});
-#endif
+    template <class Path, std::enable_if_t<std::is_constructible_v<std::string, Path>>* = nullptr>
+    CompiledModel compile_model(const Path& model_path, const AnyMap& properties = {}) {


How is wstring version is handled?

After I moved the implementation to std::filesystem::path, the "wstring version" was just explicitly calling "std::filesystem::version version" without any helpers like wstring_to_string. Now it's done implicitly

wstring -> path conversion may not work correctly in some cases, the test should be created to confirm it (see file_path.cpp) where there is dedicated constructor.

It safer to keep wstring version and make call by usingov::util::make_path conversion.

praasz · 2026-02-03T12:32:28Z

src/inference/include/openvino/runtime/core.hpp

-    template <typename... Properties>
-    util::EnableIfAllStringAny<CompiledModel, Properties...> compile_model(const std::string& model_path,
+    template <class Path, class... Properties, std::enable_if_t<std::is_constructible_v<std::string, Path>>* = nullptr>
+    util::EnableIfAllStringAny<CompiledModel, Properties...> compile_model(const Path& model_path,


What about wstring version?

src/inference/src/dev/core_impl.hpp

src/inference/include/openvino/runtime/core.hpp

…losz/openvino into almilosz/compile_model_path

praasz · 2026-02-04T06:36:25Z

src/inference/tests/functional/ov_core_test.cpp

 }
+
+TEST_F(CoreBaseTest, compile_model) {
+    generate_test_model_files("model2");


What special unicode characters are created in path?
why not use similar patter from test TEST_P(FileUtilTestP, create_directories) the test values can be re-used in other tests?

I wanted to reuse model_files_name_w, weight_files_name_w

openvino/src/inference/tests/functional/ov_core_test.cpp

Line 51 in 7a6f347

std::vector<std::wstring> model_files_name_w, weight_files_name_w;

praasz · 2026-02-04T06:36:39Z

src/inference/tests/functional/ov_core_test.cpp

+        const auto model = core.compile_model(model_path, devices.at(0), ov::AnyMap{});
+        EXPECT_TRUE(model);
+    }
+#ifdef OPENVINO_ENABLE_UNICODE_PATH_SUPPORT


Can be avoided similar like in TEST_P(FileUtilTestP, create_directories) test

praasz · 2026-02-04T06:36:49Z

src/inference/tests/functional/ov_core_test.cpp

+    const auto model_path = model_file_name;
+    const auto weight_path = weight_file_name;


Why copy is required?

praasz · 2026-02-04T06:39:52Z

src/inference/src/dev/plugin.cpp

+ov::SoPtr<ov::ICompiledModel> ov::Plugin::compile_model(const std::filesystem::path& model_path,
                                                        const ov::AnyMap& properties) const {
-    OV_PLUGIN_CALL_STATEMENT(return {m_ptr->compile_model(model_path, properties), m_so});
+    OV_PLUGIN_CALL_STATEMENT(return {m_ptr->compile_model(ov::util::path_to_string(model_path), properties), m_so});


I assume this path conversion will be remove when plugin interface will be updated?

Update core.cpp

e79b006

github-actions bot added category: inference OpenVINO Runtime library - Inference category: CPP API OpenVINO CPP API bindings labels Jan 21, 2026

praasz reviewed Jan 23, 2026

View reviewed changes

Changes till dev/plugin.cpp

626f1c6

github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Jan 29, 2026

almilosz marked this pull request as ready for review January 29, 2026 17:42

almilosz requested review from a team as code owners January 29, 2026 17:42

almilosz added 2 commits January 29, 2026 18:42

Merge branch 'master' into almilosz/compile_model_path

db81567

Fix auto device tests

38df712

almilosz requested a review from a team as a code owner February 2, 2026 10:46

github-actions bot added the category: AUTO OpenVINO AUTO device selection plugin label Feb 2, 2026

almilosz added 6 commits February 2, 2026 11:59

update

cf8a0f1

Remove wstrings overload

aed284d

Add default properties

627e64e

Merge branch 'master' of https://github.com/openvinotoolkit/openvino …

3e87302

…into almilosz/compile_model_path

Use constexpr

31f50f5

Revert "Use constexpr"

04f100e

This reverts commit 31f50f5.

praasz reviewed Feb 3, 2026

View reviewed changes

almilosz added 3 commits February 3, 2026 16:34

Revery formatting changes

16cc4d3

Merge branch 'almilosz/compile_model_path' of https://github.com/almi…

34439ac

…losz/openvino into almilosz/compile_model_path

Add tests for (w)string

7a6f347

praasz reviewed Feb 4, 2026

View reviewed changes

praasz added this to the 2026.1 milestone Feb 4, 2026

		const auto model_path = model_file_name;
		const auto weight_path = weight_file_name;

[core] Make the internal implementation of Core.compile_model(fs::path) the base implementation #33740

Are you sure you want to change the base?

[core] Make the internal implementation of Core.compile_model(fs::path) the base implementation #33740

Conversation

almilosz commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details:

Tickets:

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

almilosz commented Jan 21, 2026 •

edited

Loading