[TRANSFORMATIONS] Support new GPU RoPE pattern of glm-4-9b-chat-hf for RoPEFusion #33902
+105
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: transformations
evkotov
requested changes
Jan 30, 2026
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
CuriousPanCake
commented
Jan 30, 2026
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
CuriousPanCake
commented
Jan 30, 2026
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
CuriousPanCake
commented
Jan 30, 2026
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
CuriousPanCake
commented
Jan 30, 2026
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
evkotov
approved these changes
Jan 30, 2026
CuriousPanCake
commented
Jan 30, 2026
src/common/transformations/tests/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
mryzhov
reviewed
Feb 2, 2026
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
mryzhov
reviewed
Feb 2, 2026
src/common/transformations/tests/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends RoPE fusion support for the glm-4-9b-chat-hf model to handle GPU graph patterns, which differ from CPU patterns due to the use of Broadcast operations instead of Multiply operations in certain parts of the computation graph.
Changes:
- Updated pattern matching to accept both Multiply and Broadcast operations in the ChatGLM interleave pattern builder
- Added comprehensive GPU-specific test case for the glm-4-9b-chat-hf RoPE pattern
- Renamed existing CPU test to clarify platform-specific testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fuse_rotary_positional_embeddings.cpp (transformations) | Updated pattern matching to support Broadcast operation alongside Multiply for GPU compatibility |
| fuse_rotary_positional_embeddings.cpp (tests) | Added GPU-specific test case and renamed CPU test for clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/common/transformations/tests/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/tests/common_optimizations/fuse_rotary_positional_embeddings.cpp
Outdated
Show resolved
Hide resolved
mryzhov
approved these changes
Feb 3, 2026
Contributor
mryzhov
left a comment
mryzhov
left a comment
There was a problem hiding this comment.
The tests became a little more complicated. Perhaps we should split the model generation into separate blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
The previous fix 55eda00 for the model didn't account for GPU, which has a different model graph, so needs additional support as well.
Tickets:
Signed-off-by: Andrii Staikov [email protected]