[Snippets][CPU] Refactor verbose utils to shared common helpers #33948
+218
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aobolensk
changed the title
github-actions
bot
added
category: CPU
aobolensk
force-pushed
the
snippets-cpu-deduplicate-verbose
branch
2 times, most recently
from
727b3d4 to
811822c
Compare
v-Golubev
reviewed
Feb 3, 2026
src/plugins/intel_cpu/src/emitters/snippets/common/verbose_utils.hpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/snippets/common/verbose_utils.hpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/snippets/common/verbose_utils.hpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/snippets/aarch64/verbose.hpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/emitters/snippets/aarch64/verbose.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
22
to
48
| std::string format_memory_emitter_info(const MemoryEmitter* emitter) { | ||
| std::stringstream ss; | ||
| ss << " src_precision:" << emitter->src_prc << " dst_precision:" << emitter->dst_prc | ||
| << " load/store_element_number:" << emitter->count << " byte_offset:" << emitter->compiled_byte_offset; | ||
| return ss.str(); | ||
| } | ||
|
|
||
| /** | ||
| * @brief Format kernel emitter common info | ||
| * | ||
| * This function formats common kernel emitter information that is shared across | ||
| * all architectures. | ||
| */ | ||
| template <typename KernelEmitter> | ||
| std::string format_kernel_emitter_info(const KernelEmitter* emitter) { | ||
| std::stringstream ss; | ||
| ss << " jcp.exec_domain:" << vector_to_string(emitter->jcp.exec_domain) << " num_inputs:" << emitter->num_inputs | ||
| << " num_outputs:" << emitter->num_outputs << " num_unique_buffers:" << emitter->num_unique_buffers | ||
| << " data_ptr_regs_idx:" << vector_to_string(emitter->data_ptr_regs_idx); | ||
| return ss.str(); | ||
| } | ||
|
|
||
| /** | ||
| * @brief Format segfault detector emitter info | ||
| */ | ||
| template <typename SegfaultDetectorEmitter> | ||
| std::string format_segfault_detector_info(const SegfaultDetectorEmitter* emitter) { |
Contributor
There was a problem hiding this comment.
It looks like these helpers are not used anywhere. Could you please double check?
Contributor
Author
There was a problem hiding this comment.
Checked, they are indeed unused, removed
Contributor
There was a problem hiding this comment.
But shouldn't we reuse them for all 3 platforms instead of removing? As it is done for memory emitters
Contributor
Author
There was a problem hiding this comment.
The print content seems to be different on different platforms. So it is not as a straightforward as there
aobolensk
force-pushed
the
snippets-cpu-deduplicate-verbose
branch
from
bd8d2e3 to
1bdf9b6
Compare
aobolensk
force-pushed
the
snippets-cpu-deduplicate-verbose
branch
from
080aa84 to
e755a53
Compare
v-Golubev
reviewed
Feb 3, 2026
Comment on lines
22
to
48
| std::string format_memory_emitter_info(const MemoryEmitter* emitter) { | ||
| std::stringstream ss; | ||
| ss << " src_precision:" << emitter->src_prc << " dst_precision:" << emitter->dst_prc | ||
| << " load/store_element_number:" << emitter->count << " byte_offset:" << emitter->compiled_byte_offset; | ||
| return ss.str(); | ||
| } | ||
|
|
||
| /** | ||
| * @brief Format kernel emitter common info | ||
| * | ||
| * This function formats common kernel emitter information that is shared across | ||
| * all architectures. | ||
| */ | ||
| template <typename KernelEmitter> | ||
| std::string format_kernel_emitter_info(const KernelEmitter* emitter) { | ||
| std::stringstream ss; | ||
| ss << " jcp.exec_domain:" << vector_to_string(emitter->jcp.exec_domain) << " num_inputs:" << emitter->num_inputs | ||
| << " num_outputs:" << emitter->num_outputs << " num_unique_buffers:" << emitter->num_unique_buffers | ||
| << " data_ptr_regs_idx:" << vector_to_string(emitter->data_ptr_regs_idx); | ||
| return ss.str(); | ||
| } | ||
|
|
||
| /** | ||
| * @brief Format segfault detector emitter info | ||
| */ | ||
| template <typename SegfaultDetectorEmitter> | ||
| std::string format_segfault_detector_info(const SegfaultDetectorEmitter* emitter) { |
Contributor
There was a problem hiding this comment.
But shouldn't we reuse them for all 3 platforms instead of removing? As it is done for memory emitters
Comment on lines
25
to
44
| static std::string init_info_jit_load_memory_emitter(const jit_load_memory_emitter* emitter) { | ||
| std::stringstream ss; | ||
| std::string memory_emitter_info = init_info_jit_memory_emitter(emitter); | ||
| std::string memory_emitter_info = snippets_common::format_memory_emitter_info(emitter); | ||
| ss << "Emitter_type_name:jit_load_memory_emitter" << memory_emitter_info; | ||
| return ss.str(); | ||
| } | ||
|
|
||
| static std::string init_info_jit_load_broadcast_emitter(const jit_load_broadcast_emitter* emitter) { | ||
| std::stringstream ss; | ||
| std::string memory_emitter_info = init_info_jit_memory_emitter(emitter); | ||
| std::string memory_emitter_info = snippets_common::format_memory_emitter_info(emitter); | ||
| ss << "Emitter_type_name:jit_load_broadcast_emitter" << memory_emitter_info; | ||
| return ss.str(); | ||
| } | ||
|
|
||
| static std::string init_info_jit_store_memory_emitter(const jit_store_memory_emitter* emitter) { | ||
| std::stringstream ss; | ||
| std::string memory_emitter_info = init_info_jit_memory_emitter(emitter); | ||
| std::string memory_emitter_info = snippets_common::format_memory_emitter_info(emitter); | ||
| ss << "Emitter_type_name:jit_store_memory_emitter" << memory_emitter_info; | ||
| return ss.str(); | ||
| } |
Contributor
There was a problem hiding this comment.
Actually this code is also duplicated across the platforms. Can we move it to verbose_utils maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Unify verbose emitters across different platforms:
jit_emitter_info_t(introducejit_emitter_info_base) across x64/aarch64/riscv64Tickets: