Skip to content

[WIN] Set binaries details #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mryzhov
Copy link
Collaborator

@mryzhov mryzhov commented Jun 2, 2025

No description provided.

@mryzhov mryzhov requested a review from Copilot June 2, 2025 11:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is intended to set binary details for the OpenVINO Tokenizers project on Windows by introducing version resource configuration and updating the build scripts.

  • Added a new CMake module (cmake/vs_version.cmake) to generate a Windows version resource file.
  • Introduced a corresponding template (cmake/templates/vs_version.rc.in) for version resource configuration.
  • Updated the main CMakeLists.txt to include the new version resource module.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
cmake/vs_version.cmake Adds definitions for project binary details and a function to add the Windows version resource.
cmake/templates/vs_version.rc.in Provides the template for the version resource with relevant placeholders.
CMakeLists.txt Includes the new version resource CMake module to integrate binary details.
Comments suppressed due to low confidence (1)

cmake/templates/vs_version.rc.in:21

  • The variable PROJECT_DESCRIPTION used for the FileDescription is not defined in the CMake module. Consider adding a definition for PROJECT_DESCRIPTION in 'cmake/vs_version.cmake' or removing its usage from the resource file to avoid unexpected placeholder output.
VALUE "FileDescription", "@PROJECT_DESCRIPTION@\0"

@github-actions github-actions bot added the build label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant