feat: add openssl-sha256 to benchmark #278
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Sha256 from rust-crypto to Plonky3/Plonky3#413
Apparently the rust-crypto implementation even with NEON is perhaps 2x worse than the openssl one: RustCrypto/hashes#327 (comment)
Here I directly implement
CryptographicHasher
on the openssl sha256, let's see the benchmarks.The openssl rust crate is just a FFI wrapper for their C library. I am hoping they use the ARMv8 SHA256 intrinsics: https://mijailovic.net/2018/06/06/sha256-armv8/