Edit the list of problematic formats#689
Merged
github-actions[bot] merged 2 commits intomainfrom Dec 25, 2024
Merged
Conversation
ghost
added
documentation
Author
|
openwall/john#5615 fixed both formats. Testing: dmg-opencl, Apple DMG [PBKDF2-SHA1 3DES/AES OpenCL]... PASS
Testing: rar-opencl, RAR3 (length 5) [SHA1 OpenCL AES]... (2xOMP) PASSSource code now is probably trashing something and rawSHA512 isn't clearing the buffers properly before the test. I'll disable the Testing: raw-SHA512-free-opencl [SHA512 OpenCL (inefficient, development use mostly)]... FAILED (cmp_all(49))
Testing: raw-SHA512-opencl [SHA512 OpenCL]... PASS
[...]
1 out of 86 tests have FAILED |
ghost
pushed a commit
that referenced
this pull request
Dec 18, 2024
Add raw-SHA512-free-opencl to the list of problematic formats. Side effect of openwall/john#5613 and openwall/john#5615. Document all formats that fail and therefore need to be disabled during testing. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
ghost
ghost
pushed a commit
that referenced
this pull request
Dec 22, 2024
Remove OpenCL streebog/gost from the list of problematic formats. Side effect of openwall/john#5627. The formats have been corrected by openwall/john@c35747b. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
ghost
changed the title
ghost
pushed a commit
that referenced
this pull request
Dec 22, 2024
Remove OpenCL streebog/gost from the list of problematic formats. Side effect of openwall/john#5627. The formats have been corrected by openwall/john@469cf5a. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
added 2 commits
December 25, 2024 09:49
Add raw-SHA512-free-opencl to the list of problematic formats. Side effect of openwall/john#5613 and openwall/john#5615. Document all formats that fail and therefore need to be disabled during testing. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
Remove OpenCL streebog/gost from the list of problematic formats. Side effect of openwall/john#5627. The formats have been corrected by openwall/john@469cf5a. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Author
|
bot: MERGE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add dmg-opencl, rar-opencl to the list of problematic formats.
Document all formats that fail and therefore need to be disabled during testing.
Side effect of openwall/john#5613.
See also openwall/john#5615.
Checklist before requesting a review
Maintainer tasks
bug,ci,docker,documentation,enhancement.