Add a valid_luhn() function, and use it for SL3 #5787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by SL3 to start with, for rejecting hashes with an invalid IMEI.
That digit isn't used by the algo (and only specifying 14 digits without Luhn is and was accepted) but this change will somewhat lower the risk of misidentifying other hashes as SL3. There were actually a mockup test vector featuring an incorrect Luhn so I had to correct that as well. See openwall#5767
solardiz
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5767 (comment)
I wanted to base it on https://rosettacode.org/wiki/Luhn_test_of_credit_card_numbers#C which is nice code, but it appears the licensing would be tricky so here's instead my C implementation of the pseudo code on Wikipedia.
There were actually a mockup SL3 test vector featuring an incorrect Luhn so I had to correct that as well.