Skip to content

OpenCL HMAC: Optimize opad XOR #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

magnumripper
Copy link
Member

All shared HMAC's already had the optimization. The ntlmv2, krb5pa-md5 and krb5tgs got the changes but they did not make much of a difference. Code readability was improved while at it.

Closes #5781

All shared HMAC's already had the optimization.  The ntlmv2, krb5pa-md5
and krb5tgs got the changes but they did not make much of a difference.
Code readability was improved while at it.

Closes openwall#5781
Copy link
Member

@solardiz solardiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review thoroughly, but looks reasonable to me.

@solardiz solardiz merged commit 1bd2688 into openwall:bleeding-jumbo Jun 20, 2025
32 of 33 checks passed
@magnumripper magnumripper deleted the opencl-hmac-opt branch June 20, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try "Optimize opad XOR" for OpenCL
2 participants