feat: oid4vc specific connection screen #1756
Conversation
Signed-off-by: Christian Lippa <[email protected]>
🦋 Changeset detectedLatest commit: 3189355 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
ef5931c to
8074970
Compare
Signed-off-by: Christian Lippa <[email protected]>
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
8074970 to
e9695b2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
+ Coverage 52.65% 53.16% +0.51%
==========================================
Files 320 321 +1
Lines 11278 11310 +32
Branches 3216 3221 +5
==========================================
+ Hits 5938 6013 +75
+ Misses 5292 5249 -43
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Christian Lippa <[email protected]>
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
2a2e256 to
9fe615e
Compare
Signed-off-by: LippaC-OPS <[email protected]>
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
2b1e9ec to
b3421e9
Compare
Signed-off-by: LippaC-OPS <[email protected]>
Signed-off-by: LippaC-OPS <[email protected]>
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
e9e9ce1 to
7e38fdf
Compare
| ]) | ||
| const notifications = useNotifications({ openIDUri: openIDUri, openIDPresentationUri: openIDPresentationUri }) | ||
| const { agent } = useAppAgent() | ||
| const oobRecord = useOutOfBandById(oobRecordId ?? '') |
There was a problem hiding this comment.
If this screen is only for OpenID then you dont need any AnonCreds related hooks here
the useOutOfBandById, useConnectionByOutOfBandId are not needed
| } | ||
|
|
||
| if ( | ||
| (notification as W3cCredentialRecord).type === 'W3cCredentialRecord' || |
There was a problem hiding this comment.
Shouldn't we remove OIDC from "Connection" screen? not sure
@timbl-ont
There was a problem hiding this comment.
I can remove it from there, I just didnt want to mess anything up on that screen
There was a problem hiding this comment.
@MosCD3 Did you mean W3C? That is a valid openid4vc credential type.
There was a problem hiding this comment.
All three should be supported in this screen.
There was a problem hiding this comment.
I removed them from the old connection screen is that fine?
Signed-off-by: LippaC-OPS <[email protected]>
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
103f248 to
b30d777
Compare
|
Is it ok if we hold off on merging this until the RN 81 upgrade PR is merged? It's very nearly done |
Signed-off-by: LippaC-OPS <[email protected]>
Signed-off-by: LippaC-OPS <[email protected]>
Signed-off-by: LippaC-OPS <[email protected]>
Signed-off-by: LippaC-OPS <[email protected]>
LippaC-OPS
force-pushed
the
feat/oid4vc-specific-connection-screen
branch
from
b8db110 to
3189355
Compare
|
5 participants
Summary of Changes
Add connection screen specifically for Open ID Credentials
Testing Instructions
Scan or add OpenID credentials
Acceptance Criteria
Replace this text with the acceptance criteria that must be met for this PR to be approved.
Screenshots, videos, or gifs
Breaking change guide
Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A
Related Issues
Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓