Add support for Dynamic DNS Client configuration to the OpenWRT backend #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okraits
force-pushed
the
tdt-ddns
branch
4 times, most recently
from
b4c29ac
to
4093bea
Compare
okraits
force-pushed
the
tdt-ddns
branch
2 times, most recently
from
9ce2c31
to
7595028
Compare
jerbob
reviewed
Nov 5, 2018
| resultdict = OrderedDict((('.name', uci_name), | ||
| ('.type', 'service'))) | ||
| for key, value in provider.items(): | ||
| resultdict[key] = value |
There was a problem hiding this comment.
This could probably be written as:
resultdict.update(provider)
okraits
force-pushed
the
tdt-ddns
branch
2 times, most recently
from
7fc2a56
to
4b34020
Compare
|
@nemesisdesign I finished this PR from my side. |
Signed-off-by: Konrad Kreitmair <[email protected]>
Signed-off-by: Konrad Kreitmair <[email protected]>
Signed-off-by: Konrad Kreitmair <[email protected]>
Signed-off-by: Konrad Kreitmair <[email protected]>
|
@nemesisdesign I rebased this to current master. Please let me know if there's anything which keeps this from getting merged. |
okraits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Dynamic DNS Client configuration to the OpenWRT backend:
https://openwrt.org/docs/guide-user/base-system/ddns
Todos: