Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Added support for custom zt ifname #284 #285

Merged
merged 11 commits into from
Sep 22, 2023
Merged

[feature] Added support for custom zt ifname #284 #285

merged 11 commits into from
Sep 22, 2023

Conversation

Aryamanz29
Copy link
Member

Closes #284

@Aryamanz29 Aryamanz29 self-assigned this Aug 13, 2023
@coveralls
Copy link

coveralls commented Aug 13, 2023 •
edited
Loading

Coverage Status

coverage: 98.728% (-0.02%) from 98.752% when pulling 87f0018 on issue-284/add-support-for-zt-ifname into 2ebc2b2 on gsoc23.

@Aryamanz29 Aryamanz29 marked this pull request as ready for review August 13, 2023 12:57
Aryamanz29
Aryamanz29 commented Aug 16, 2023
View reviewed changes
Copy link
Member Author

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 August : Weekly meet (requested-changes)

@Aryamanz29
[req-changes] Worked on weekly sync req-changes
d8feb9f 
- Rename 'zt_ifname' to 'ifname'
- Provided default values for 'copy_config_path' and 'config_path' options
@Aryamanz29 Aryamanz29 mentioned this pull request Aug 17, 2023
Merged
2 tasks
nemesifier
nemesifier requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! See my comments below.

docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch 2 times, most recently from 4a47582 to aebc310 Compare August 21, 2023 12:45
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch from aebc310 to b226a66 Compare August 21, 2023 12:55
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch from c4b5b58 to 8071a50 Compare August 24, 2023 05:40
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch from 086ffc9 to a8a0e1e Compare August 25, 2023 11:21
nemesifier
nemesifier requested changes Aug 28, 2023
View reviewed changes
docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
netjsonconfig/backends/openwrt/schema.py Show resolved Hide resolved
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch 7 times, most recently from 9e69c35 to 0486da7 Compare August 29, 2023 09:45
@Aryamanz29
[req-changes] Reverted schema properties change and improved docs
75817ab 
I changed the example in 'Advanced Configuration' because ZeroTier port configuration
can be done using the UCI option 'port' without the need for a `local.conf` file.

Instead, I have updated the example to demonstrate
how to blacklist a specific physical network path.
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch from 0486da7 to 75817ab Compare August 29, 2023 11:09
nemesifier
nemesifier requested changes Aug 29, 2023
View reviewed changes
docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
pandafy
pandafy requested changes Sep 1, 2023
View reviewed changes
docs/source/backends/zerotier.rst Outdated Show resolved Hide resolved
netjsonconfig/backends/openwrt/converters/zerotier.py Outdated Show resolved Hide resolved
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch from 3ab3c86 to a0405be Compare September 1, 2023 11:56
@Aryamanz29
[req-changes] Added zt ifname fallback test
00acef5 
- Improved "secret" property description.
@Aryamanz29 Aryamanz29 force-pushed the issue-284/add-support-for-zt-ifname branch from a0405be to 00acef5 Compare September 1, 2023 11:59
@pandafy pandafy mentioned this pull request Sep 5, 2023
Merged
2 tasks
nemesifier
nemesifier approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nemesifier
Copy link
Member

@pandafy please confirm.

@pandafy
Copy link
Member

pandafy commented Sep 22, 2023

LGTM! 👍🏼

@nemesifier nemesifier merged commit 67ab548 into gsoc23 Sep 22, 2023
4 checks passed
@nemesifier nemesifier deleted the issue-284/add-support-for-zt-ifname branch September 22, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

@atb00ker atb00ker Awaiting requested review from atb00ker

@pandafy pandafy Awaiting requested review from pandafy

Assignees

@Aryamanz29 Aryamanz29

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aryamanz29 @coveralls @nemesifier @pandafy @atb00ker