Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Renamed celery monitoring tasks with leading underscores #569 #570

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Apr 4, 2024

Fixes #569

Checks:

  • I have manually tested the proposed changes
  • I have written new test cases to avoid regressions (if necessary)
  • I have updated the documentation (e.g. README.rst)

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what I meant.
I did not mean to change the name.

I meant to swap the names of _timeseries_write and timeseries_write.
I think the celery task should be named timeseries_write and the function used internally in the application should be named _timeseries_write, while now is the opposite.

@pandafy pandafy force-pushed the issues/569-rename---timeseries-write-tasks branch from 285b426 to 4411c40 Compare April 4, 2024 16:39
@pandafy pandafy force-pushed the issues/569-rename---timeseries-write-tasks branch from 4411c40 to cd21359 Compare April 4, 2024 17:43
@nemesifier nemesifier merged commit a1f7735 into master Apr 4, 2024
11 checks passed
@nemesifier nemesifier deleted the issues/569-rename---timeseries-write-tasks branch April 4, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change] Rename celery tasks _timeseries_write and _timeseries_batch_write
2 participants