[feature] Added view to collect email in SAML registration#557
Merged
nemesifier merged 3 commits intomasterfrom Nov 19, 2024
Merged
[feature] Added view to collect email in SAML registration#557nemesifier merged 3 commits intomasterfrom
nemesifier merged 3 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pandafy
force-pushed
the
saml-intermediate-view
branch
4 times, most recently
from
d5426db to
cbaef31
Compare
pandafy
force-pushed
the
saml-intermediate-view
branch
4 times, most recently
from
4a7897f to
6f84147
Compare
If the IdP does not include email address in SAML response, then the user will be asked for email during sign-up.
pandafy
force-pushed
the
saml-intermediate-view
branch
from
6f84147 to
3d3b7a5
Compare
nemesifier
reviewed
Nov 7, 2024
nemesifier
requested changes
Nov 19, 2024
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Is the fur translation missing?
| #: templates/djangosaml2/login_additional_info.html:6 | ||
| msgid "" | ||
| "It looks like we didn't receive your email from your identity provider.</" | ||
| "br>Please enter your email address below to complete setting up your account." |
Member
There was a problem hiding this comment.
is the <br> tag here and in the other translation files intentional and correct? I don't remember we use HTML tags in the translations here.
Member
Author
There was a problem hiding this comment.
I can try splitting the string in two different paragraphs.
This old StackOverflow post says that it's okay to have HTML tag in the string.
nemesifier
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Description of Changes
If the IdP does not include email address in SAML response, then the user will be asked for email during sign-up.