[admin/api] Make batch user creation organization field readonly #609 #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eeshu-Yadav
force-pushed
the
issues/609-batch-user-org-field-readonly
branch
from
017eddb to
b5023ad
Compare
Contributor
Author
|
@pandafy kindly review this |
Member
|
@Eeshu-Yadav what's the point of reviewing if you don't follow up? Please follow up with #621. |
Eeshu-Yadav
force-pushed
the
issues/609-batch-user-org-field-readonly
branch
from
b5023ad to
1c7eba9
Compare
Contributor
Author
ok |
Eeshu-Yadav
force-pushed
the
issues/609-batch-user-org-field-readonly
branch
6 times, most recently
from
7ba30e3 to
1402441
Compare
…wisp#609 This change prevents modification of the organization field for existing RadiusBatch objects in both admin interface and REST API. When editing existing batch objects, the organization field is now readonly to maintain data integrity and prevent accidental organization changes. Changes: - Added organization field to readonly_fields in RadiusBatchAdmin for existing objects - Created RadiusBatchUpdateSerializer with organization as readonly field - Added BatchUpdateView for handling batch detail API operations - Added comprehensive tests for both admin and API readonly functionality Fixes openwisp#609
- Document GET, PUT, and PATCH methods for batch retrieve/update - Clarify that organization field is read-only for existing objects - List all read-only and updatable fields
Eeshu-Yadav
force-pushed
the
issues/609-batch-user-org-field-readonly
branch
from
1402441 to
a7e3f33
Compare
- Resolve remaining git conflict markers in admin.py - Fix whitespace issue in serializers.py - Format rest-api.rst documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the organization field readonly for existing RadiusBatch objects in both the admin interface and REST API, addressing issue #609.
When the batch user creation object has been created, there's no point in changing the organization field, and this change disallows modification to maintain data integrity.
Changes
Admin Interface
RadiusBatchAdmin.get_readonly_fields()to includeorganizationfield for existing objectsREST API
RadiusBatchUpdateSerializerwith organization as readonly fieldBatchUpdateViewfor handling batch detail operations (retrieve/update)/radius/batch/<uuid:pk>/)Testing
test_radiusbatch_organization_readonly_for_existing_objectstest_radiusbatch_organization_editable_for_new_objectstest_batch_update_organization_readonlytest_batch_retrieve_and_update_apitest_batch_update_permissionsChecklist
Fixes #609