Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions openwisp_users/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,36 @@
logger = logging.getLogger(__name__)


class SensitiveFieldsAdminMixin:
def get_fieldsets(self, request, obj=None):
fieldsets = super().get_fieldsets(request, obj)
if request.user.is_superuser:
return fieldsets
sensitive_fields = getattr(self.model, "sensitive_fields", [])
if not sensitive_fields:
return fieldsets
fieldsets = deepcopy(fieldsets)
for fieldset in fieldsets:
fieldset_fields = fieldset[1].get("fields", ())
if isinstance(fieldset_fields, (list, tuple)):
fieldset[1]["fields"] = tuple(
field for field in fieldset_fields
if field not in sensitive_fields
)
return fieldsets

def get_readonly_fields(self, request, obj=None):
readonly = super().get_readonly_fields(request, obj)
if request.user.is_superuser:
return readonly
sensitive_fields = getattr(self.model, "sensitive_fields", [])
if not sensitive_fields:
return readonly
return list(readonly) + [
field for field in sensitive_fields if field not in readonly
]


class EmailAddressInline(admin.StackedInline):
model = EmailAddress
extra = 0
Expand Down
13 changes: 13 additions & 0 deletions openwisp_users/api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
OrganizationOwner = load_model("openwisp_users", "OrganizationOwner")


class SensitiveFieldsSerializerMixin:
def get_fields(self):
fields = super().get_fields()
request = self.context.get("request")
if not request or request.user.is_superuser:
return fields
model = self.Meta.model
sensitive_fields = getattr(model, "sensitive_fields", [])
for field_name in sensitive_fields:
fields.pop(field_name, None)
return fields


class OrganizationSerializer(ValidatedModelSerializer):
class Meta:
model = Organization
Expand Down