[payment] Fixed payment flow with captive_portal_sync_auth #950 #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both payment_requires_internet and captive_portal_sync_auth are enabled, the payment flow was not working properly. Users were redirected to /payment/draft instead of /payment/process after captive portal login. The issue was that proceedToPayment flag was lost during page reload caused by synchronous captive portal form submission. The fix persists proceedToPayment in cookies/localStorage (similar to mustLogin) so it survives the page reload. Changes: - Added captivePortalSyncAuth to payment-status component props - Store proceedToPayment in cookie/localStorage when captivePortalSyncAuth is enabled - Resolve proceedToPayment from cookie/localStorage in status component finalOperations - Added comprehensive test coverage for the fix Fixes openwisp#950
Eeshu-Yadav
force-pushed
the
issues/950-captive-portal-payment-auth-conflict
branch
from
a4d90a4 to
34ab3d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
When both payment_requires_internet and captive_portal_sync_auth are enabled, the payment flow was not working properly. Users were redirected to /payment/draft instead of /payment/process after captive portal login.
The issue was that proceedToPayment flag was lost during page reload caused by synchronous captive portal form submission. The fix persists proceedToPayment in cookies/localStorage (similar to mustLogin) so it survives the page reload.
Changes:
Fixes #950