[change] Allowed showing failure messages coming from captive portal #604 #838
Conversation
praptisharma28
changed the title
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
Sorry for the wait @praptisharma28, this has been buried under a pile of open PRs.
What steps can we do to manually test this?
Can you add at least one screenshot to the PR description or to a reply here please?
See my comment below.
| import Loader from "../../utils/loader"; | ||
| import needsVerify from "../../utils/needs-verify"; | ||
| import Login from "../login"; | ||
| import LoginComponent from "../login"; |
There was a problem hiding this comment.
I don't understand where this LoginComponent is coming from. Is this some naming convention in react or what? I can't see the definition of this class.
There was a problem hiding this comment.
@nemesifier here I have mentioned that I was getting an ESlint error, but what error in particular, I don't remember as it's been long. Got a new laptop hence need to set it up again and check, will let you know today itself.
There was a problem hiding this comment.
Hii @nemesifier , I am getting this ESlint error:
error Using exported name 'Login' as identifier for default export import/no-named-as-default
The error occurs on 2 files:
openwisp/openwisp-wifi-login-pages/client/components/organization-wrapper/organization-wrapper.js openwisp/openwisp-wifi-login-pages/client/components/organization-wrapper/organization-wrapper.test.js
and i guess, it is because this ESLint rule (import/no-named-as-default) is warning me about a potentially confusing pattern in imports.
Here's the screenshot:
2 participants
…#604
Closes #604
Checklist
Reference to Existing Issue
Closes #604 .
Description of Changes
captive-portal-handler.jsto handle authentication failure detection and error messaging.Also:
import LoginComponent from "../login";