iOS 11 update #7
Conversation
Modernized Podfile by wrapping pods in a Target. Removed Testflight. Its hasn't been supported for years. Fixed some changed OpenGL constant names.
|
@neoplastic Thanks for this! We are currently looking for additional testers to check this out and see if they can further improve on your fixes. Stay tuned! |
There was a problem hiding this comment.
Hi. Quick background: I just read the recent article about the lego robot, and followed the links regarding the iOS app. I'm happy to help a bit. I'm an iOS developer as well as a chemist. I thought I'd start by just giving a cursory review of David's PR
The PR looks good given its purpose. Great Job! I got the project to build on a iPhone 8+ simulator. I have just two minor comments.
| @@ -261,8 +261,8 @@ -(void) loadDrawGroupsInContext:(EAGLContext *)context | |||
| int bboffset = [[meshDictionary objectForKey:@"bboxes"] intValue]; | |||
|
|
|||
| if (bboffset > 0) { | |||
|
|
|||
| int numBBoxen = [[meshDictionary objectForKey:@"names"] count]; | |||
| NSArray *meshes = [meshDictionary objectForKey:@"names"]; | |||
There was a problem hiding this comment.
if you're changing this line anyway, perhaps this would be clearer
NSArray *meshes = meshDictionary[@"names"];
| @@ -82,7 +82,7 @@ - (void)viewDidLoad | |||
|
|
|||
| -(void) viewDidAppear:(BOOL)animated | |||
| { | |||
| [TestFlight passCheckpoint:@"Search view displayed"]; | |||
|
|
|||
There was a problem hiding this comment.
if deleting the TestFlight line, might as well delete the method, particularly b/c it's not even calling super`.
Might as well delete the unused didReceiveMemoryWarning
|
@chrisbrandow Thanks for this! It is encouraging that it worked in a second person's hands. We're going to make a push on this in the coming weeks. |
|
Sorry, I got pretty busy and forgot to check in to this code review! Yeah, it was a quick and dirty job just to get this working, I did it on the train to work. Thanks @chrisbrandow there's probably a lot more code that could be cleaned up and modernised along with the two you've found. Honestly, I hadn't touched Obj-C for years now so it was nice making those connections again. If I get time again, I'll look at getting it laying out correctly with safe areas (iPhone X) |
Preliminarily resolves #6
This fixes some reds and modernises some of the code and app attributes.
This is far from complete.