Skip to content

luci-app-xinetd: fixes #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2025
Merged

luci-app-xinetd: fixes #7689

merged 2 commits into from
Mar 19, 2025

Conversation

feckert
Copy link
Member

@feckert feckert commented Mar 19, 2025 •
edited
Loading

  • make the server configuration option mandatory
  • do not show description in table overview (Bind address)

Fixes: #7664

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

@feckert feckert mentioned this pull request Mar 19, 2025
Closed
1 task
@feckert feckert changed the title luci-app-xinetd: make the server configuration option mandatory luci-app-xinetd: fixes Mar 19, 2025
@lars18th
Copy link

Tested and working.

@feckert feckert merged commit 6d7397e into openwrt:master Mar 19, 2025
5 checks passed
@feckert feckert deleted the pr/20250319-luci-app-xinetd branch March 19, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

luci-app-xinetd: incorrect handling of REDIRECT option in the UI
2 participants
@feckert @lars18th