luci-theme-bootstrap: use system font stack with CSS custom properties#8082
luci-theme-bootstrap: use system font stack with CSS custom properties#8082314systems wants to merge 1 commit intoopenwrt:masterfrom
Conversation
|
Can you further detail advantages, how this might improve upon what we have today? |
themes/luci-theme-bootstrap/htdocs/luci-static/bootstrap/cascade.css
Outdated
Show resolved
Hide resolved
themes/luci-theme-bootstrap/htdocs/luci-static/bootstrap/cascade.css
Outdated
Show resolved
Hide resolved
Replace hardcoded font-family declarations with CSS custom properties (--font-sans, --font-serif, --font-mono) that utilize system UI fonts. Signed-off-by: Akihiro Nagai <[email protected]>
543de06 to
0e17c6c
Compare
|
@314systems The source code should be fine. |
|
@systemcrash |
feckert
left a comment
There was a problem hiding this comment.
I fin with that. But my point is that you change the current font.
| button, | ||
| select { | ||
| font-family: "Helvetica Neue", Helvetica, Arial, sans-serif; | ||
| font-family: var(--font-sans); |
There was a problem hiding this comment.
You are changing the current font:
--font-sans: ui-sans-serif, system-ui, sans-serif;
There was a problem hiding this comment.
This uses the native system UI fonts, avoids legacy Helvetica/Arial overrides, and is more in line with modern web typography practices.
| color-scheme: light; | ||
|
|
||
| --font-sans: ui-sans-serif, system-ui, sans-serif; | ||
| --font-serif: ui-serif, serif; |
|
Closed by 3c3a5e2 |
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile