luci-theme-bootstrap: restyle wireless overview#8271
luci-theme-bootstrap: restyle wireless overview#8271GeorgeSapkin wants to merge 1 commit intoopenwrt:masterfrom
Conversation
|
|
||
| body[data-page="admin-network-wireless"] .tr:not([data-sid^="radio"]) .td[data-name="_badge"] div.center:before { | ||
| color: #999; | ||
| content: '↳'; |
There was a problem hiding this comment.
Might I suggest one of these
https://www.alt-codes.net/arrow_alt_codes.php
e.g. ↳ -> ↳
There was a problem hiding this comment.
A more robust solution would be using an SVG. Maybe there's an open-source icon pack somewhere.
There was a problem hiding this comment.
emoji are where it's at. SVG is an extra fetch.
There was a problem hiding this comment.
That's the issue as these are rendered all over the place depending on the browser, OS and device. But I don't have any feelings about the implementation, so I'm up for any changes.
f7dad98 to
bc7df33
Compare
Restyle wireless overview to make it clearer which SSIDs belong to which radios. Signed-off-by: George Sapkin <george@sapk.in>
bc7df33 to
533d0fb
Compare
|
@systemcrash any other feedback? 👀 I think there must be a much better way to structure this. |
|
Directly in the rendered HTML? |
|
I was trying to avoid changing the HTML output so as not to break any other themes. What I was trying to ask was if there's a better way to structure the styles. As these look somewhat off to me. |
|
While outside of the scope of your proposed change, I am wondering if it makes sense to keep the hierarchical structure (group by radio) of the wireless overview at all, especially considering modern wireless characteristics such as MLO etc. Maybe it should be changed into a flat list of wireless network tiles/cards. The hardware details (radio name, channel, band) could be duplicated in each wireless card (e.g. a band indicator in the upper left corner). Common operations such as "add radio" and "scan" could prompt for the phy (radio) to use if multiple are present. |
|
I find the wireless overview page and sub-views confusing so I agree it could be improved. My biggest gripe is that device settings are in the interface dialog, even though they clearly are per device. Furthermore, some settings should be global (e.g. country for reg domain), yet there are at the interface level. This comes up on the forum from time to time where users try to set different device setting for interfaces on the same radio and it doesn't work. It would make sense to me that device settings would be separate. I'm curios to find out why the interface is that way now, as I feel there's a hidden fence somewhere. I haven't thought about this too much, so I can't really imagine a simpler UI, apart from having two separate lists: devices and interfaces, and splitting settings accordingly. |
|
Yeah, it's not a trivial change. There's quite a bit of lifting going on in network and wifi settings. But the layout is not too difficult. I'm slaying dragons at the moment so I won't get to anything like this in a while. |
Restyle wireless overview to make it clearer which SSIDs belong to which radios.
More of an RFC, as this is surely not the best way to do it. I wanted to do this purely through theming without breaking any other screens.
Before:
After:
Mobile:
Mobile (tiny screen):
Tested on 25.12-rc3 with desktop Firefox and Chromium, and mobile Firefox and Chrome on Android. Mobile rendering of
↳seems to be device-dependent, so this bit might need some rethinking.cc: @systemcrash