luci-base: implement the move method for CBIJSONConfig#8348
Open
emzet wants to merge 1 commit intoopenwrt:masterfrom
Open
luci-base: implement the move method for CBIJSONConfig#8348emzet wants to merge 1 commit intoopenwrt:masterfrom
emzet wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
- convert the data object into an array - find the indices for section_id1 and section_id2 - move the section_id1 item to the correct position - recalculate the indices for the entire data object - convert the array back into an object Signed-off-by: Marek Zavacky <[email protected]>
emzet
force-pushed
the
feature/luci-base-form
branch
from
d68f4b1 to
8312508
Compare
emzet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, the original implementation was missing. Here is the actual implementation. It works correctly with
GridSection(including nested ones) and handles moving items internally, which is useful when you need to save the data asJSONfile, not just visualize it via the UI.The logic is as follows:
dataobject into an arraysection_id1andsection_id2section_id1item to the correct position