Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luajit: LuaJIT has a "rolling release" where we should follow git HEAD #25299

Open
graysky2 opened this issue Nov 11, 2024 · 4 comments
Open

Comments

@graysky2
Copy link
Contributor

graysky2 commented Nov 11, 2024

Maintainer: @milani
Environment: build system

Description: LuaJIT has a "rolling release" where we should follow git HEAD[1]. I believe that the currently tagged version is tracking code from 2017. Can we update our package to track HEAD? I made an attempt to modify it based off lang/luajit2/Makefile but the patches need a refresh.

  1. https://luajit.org/download.html
diff --git a/lang/luajit/Makefile b/lang/luajit/Makefile
index c5d86a7065f5..c81168810f63 100644
--- a/lang/luajit/Makefile
+++ b/lang/luajit/Makefile
@@ -1,13 +1,14 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=luajit
-PKG_VERSION:=2.1.0-beta3
-PKG_RELEASE:=7
+PKG_SOURCE_DATE:=2024-10-02
+PKG_VERSION:=2.1.$(subst -,.,$(PKG_SOURCE_DATE))
+PKG_RELEASE:=1
 
-PKG_SOURCE:=LuaJIT-$(PKG_VERSION).tar.gz
-PKG_SOURCE_URL:=https://luajit.org/download
-PKG_HASH:=1ad2e34b111c802f9d0cdf019e986909123237a28c746b21295b63c9e785d9c3
-PKG_BUILD_DIR:=$(BUILD_DIR)/LuaJIT-$(PKG_VERSION)
+PKG_SOURCE_PROTO:=git
+PKG_SOURCE_URL:=https://github.com/LuaJIT/LuaJIT
+PKG_SOURCE_VERSION:=97813fb924edf822455f91a5fbbdfdb349e5984f
+PKG_MIRROR_HASH:=cbf1647acbd340c62b9c342dae43290762efa1b26d8bf8457f143fabf8ed86c7
 
 PKG_MAINTAINER:=Morteza Milani <[email protected]>
 PKG_LICENSE:=MIT
-- 
2.47.0
@Ra2-IFV
Copy link
Contributor

Ra2-IFV commented Nov 13, 2024

I refreshed patches, take a look at here: https://github.com/Ra2-IFV/openwrt-packages/tree/feat_update-luajit
Also a binary package is available at here, but I cannot test it or extract it, gzip tells me it's not a valid file
luajit-2.1-r20241013.apk.gz

@Ra2-IFV
Copy link
Contributor

Ra2-IFV commented Nov 13, 2024

You create the pull request? Or let me do this

@Ra2-IFV
Copy link
Contributor

Ra2-IFV commented Nov 13, 2024

Also I kinda did the same changes as #25336, this may cause conflicts but very easy to solve

@graysky2
Copy link
Contributor Author

@Ra2-IFV - Please create a PR since you did the work.

graysky2 added a commit to graysky2/packages that referenced this issue Nov 16, 2024
LuaJIT has a "rolling release" where we should follow git HEAD[1].
I believe that the currently tagged version is tracking code from
2017.  This PR updates the Makefile to latest HEAD.

Closes openwrt#25299

Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne

Signed-off-by: John Audia <[email protected]>
graysky2 added a commit to graysky2/packages that referenced this issue Nov 16, 2024
LuaJIT has a "rolling release" where we should follow git HEAD[1].
I believe that the currently tagged version is tracking code from
2017.  This PR updates the Makefile to latest HEAD.

Closes openwrt#25299

1. https://luajit.org/download.html

Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne

Signed-off-by: John Audia <[email protected]>
graysky2 added a commit to graysky2/packages that referenced this issue Nov 16, 2024
LuaJIT has a "rolling release" where we should follow git HEAD[1].
I believe that the currently tagged version is tracking code from
2017.  This PR updates the Makefile to latest HEAD.

Closes openwrt#25299

1. https://luajit.org/download.html

Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne

Signed-off-by: John Audia <[email protected]>
graysky2 added a commit to graysky2/packages that referenced this issue Nov 16, 2024
LuaJIT has a "rolling release" where we should follow git HEAD[1].
I believe that the currently tagged version is tracking code from
2017.  This PR updates the Makefile to latest HEAD.

Closes openwrt#25299

1. https://luajit.org/download.html

Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne

Signed-off-by: John Audia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants