-
Notifications
You must be signed in to change notification settings - Fork 3.8k
tcpreplay: add libbpf dependency #27883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1488fa6 to
2d7d46b
Compare
Since compiling tcpbridge requires linking libbpf.so.1, compiling tcpbridge first may result in compilation failure, like: Package tcpbridge is missing dependencies for the following libraries: libbpf.so.1 The simplest way to solve it is to add libbpf dependency in Makefile Signed-off-by: TeleostNaCl Dai <[email protected]>
2d7d46b to
795bdac
Compare
|
Tcpreplay compiles ok in buildbot (with all libraries supposedly present), so I wonder about your findings about a missing dependency. |
Looking into I'm fine to have this be a dependency of |
| URL:=http://tcpreplay.appneta.com/ | ||
| MAINTAINER:=Alexandru Ardelean <[email protected]> | ||
| DEPENDS:=+librt +libpcap +libdnet +USE_MUSL:musl-fts | ||
| DEPENDS:=+librt +libpcap +libdnet +libbpf +USE_MUSL:musl-fts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure libbpf will be used ?
if i look into
CONFIGURE_ARGS += \
--enable-force-pf \
...................
This will force PF_PACKET over libbpf.
So, libbpf will be pulled as a dependency, but will not be used by tcpreplay.
commodo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need a Config.in option, where libbpf is chosen in a menuconfig.
By default, PF_PACKET is used (standard Linux kernel socket filtering).
libbpf may be a bit more feature-rich, but currently it needs more changes to work.
|
Hello @commodo Meanwhile, here are some adds: When I select The wrong message is The I use ArchLinux to compile OpenWrt. |
Oh Give me a few days to look into this. |
|
I have another device:
In this device, I don't select libbpf package, but I also compile tcpreplay failed, and the output like this: It also tells me |
Since compiling tcpbridge requires linking libbpf.so.1, compiling tcpbridge first may result in compilation failure, like:
Package tcpbridge is missing dependencies for the following libraries: libbpf.so.1
The simplest way to solve it is to add libbpf dependency in Makefile
📦 Package Details
Maintainer: Alexandru Ardelean [email protected]
Description:
Add a dependency on libbpf in tcprepaly
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am