Skip to content

bind: backport patch replace automatic empty zones#28053

Merged
nmeyerhans merged 1 commit intoopenwrt:masterfrom
pprindeville:bind-addzone-empties
Feb 1, 2026
Merged

bind: backport patch replace automatic empty zones#28053
nmeyerhans merged 1 commit intoopenwrt:masterfrom
pprindeville:bind-addzone-empties

Conversation

@pprindeville
Copy link
Member

📦 Package Details

Maintainer: @nmeyerhans, me

Description:
Backport upstream patch that allows us to replace the dynamically created empty zones for RFC-1918 addresses.


🧪 Run Testing Details

  • OpenWrt Version: HEAD
  • OpenWrt Target/Subtarget: x86_64/generic
  • OpenWrt Device: pc-engines-apu6

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
  • It is structured in a way that it is potentially upstreamable

@pprindeville pprindeville marked this pull request as draft December 10, 2025 22:35
@pprindeville pprindeville force-pushed the bind-addzone-empties branch 3 times, most recently from 54e81d0 to 50982b2 Compare December 13, 2025 21:48
@nmeyerhans nmeyerhans self-requested a review December 19, 2025 19:05
@nmeyerhans nmeyerhans self-assigned this Dec 19, 2025
@pprindeville pprindeville force-pushed the bind-addzone-empties branch 2 times, most recently from 0e722d9 to b8fc771 Compare December 22, 2025 20:19
@pprindeville
Copy link
Member Author

pprindeville commented Dec 22, 2025

You can't have a single file with multiple commits in it, correct? I think it stops after the end of the first patch... I'll have to split the upstream PR into constituent commits.

@pprindeville
Copy link
Member Author

With this patch, I've not been able to get isc-dhcp to update the synthetic empty-zone. I still require disable-empty-zone 168.192.in-addr.arpa; in by named.conf options {} section.

The RFC-1918 zones are automatically synthesized locally by bind
to avoid forwarding queries about them to root nameservers.  As
a result, we can't easily replace them with rndc addzone on the
fly.  We need this for DHCP integration.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
@pprindeville pprindeville changed the title Bind addzone empties bind: backport patch replace automatic empty zones Jan 26, 2026
@pprindeville pprindeville marked this pull request as ready for review January 26, 2026 01:16
@pprindeville
Copy link
Member Author

@nmeyerhans Okay to merge?

@nmeyerhans nmeyerhans merged commit 505ca0a into openwrt:master Feb 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants