-
Notifications
You must be signed in to change notification settings - Fork 3.8k
ddns-scripts: add multiple DNS records support for aliyun ddns #28055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please do the following changes,
|
Done, thank you for your reply |
|
Unfortunately, I noticed something else. The indentation in the file is a Thanks |
Okay,Done |
|
Please squash the 3 commits to one. Then it is ready for merge |
Hi, i hvae squashed the 3 commits to one |
|
You still have to update the commit message with the For example: |
|
Everything is ok, finally. |
|
@feckert @GeorgeSapkin |
GeorgeSapkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message needs to follow the 50/75 rule as per the submissions guidelines and you need to use your real name both in author and sign-off.
Added logic to extract and match DNS record ID from parameters, with fallback to default selection if no match is found. Signed-off-by: QiLei Niu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
ddns-scripts: Added logic to extract and match DNS record ID from parameters,
with fallback to default selection if no match is found.