Skip to content

Conversation

@monokoo
Copy link

@monokoo monokoo commented Dec 11, 2025

ddns-scripts: Added logic to extract and match DNS record ID from parameters,
with fallback to default selection if no match is found.

@monokoo monokoo changed the title add multiple DNS records support for aliyun ddns ddns-scripts: add multiple DNS records support for aliyun ddns Dec 11, 2025
@feckert
Copy link
Member

feckert commented Dec 11, 2025

Please do the following changes,

  • Update the commit message with the prefix ddns-scripts:
  • Do not exceed the 80-character limit for the commit message.
  • Bump the PKG_RELEASE by one the Makefile

@monokoo
Copy link
Author

monokoo commented Dec 12, 2025

Please do the following changes,

  • Update the commit message with the prefix ddns-scripts:
  • Do not exceed the 80-character limit for the commit message.
  • Bump the PKG_RELEASE by one the Makefile

Done, thank you for your reply

@feckert
Copy link
Member

feckert commented Dec 12, 2025

Unfortunately, I noticed something else. The indentation in the file is a tab.
Your changes have a space as indentation. That is not consistent.
Could you please adjust this.

Thanks

@monokoo
Copy link
Author

monokoo commented Dec 12, 2025

Unfortunately, I noticed something else. The indentation in the file is a tab. Your changes have a space as indentation. That is not consistent. Could you please adjust this.

Thanks

Okay,Done

@feckert
Copy link
Member

feckert commented Dec 12, 2025

Please squash the 3 commits to one. Then it is ready for merge

@monokoo
Copy link
Author

monokoo commented Dec 15, 2025

Please squash the 3 commits to one. Then it is ready for merge

Hi, i hvae squashed the 3 commits to one

@feckert
Copy link
Member

feckert commented Dec 15, 2025

You still have to update the commit message with the ddns-script: prefix. As you already have done in your PR description. The commit message gets into the repository not the PR description.

For example:

ddns-scripts: Add logic to extract and match DNS record ID from parameters

If the extract does not find any record then fallback to default selection.
``

https://github.com/openwrt/packages/pull/28055/commits

@monokoo
Copy link
Author

monokoo commented Dec 15, 2025

Everything is ok, finally.

@monokoo
Copy link
Author

monokoo commented Dec 16, 2025

@feckert @GeorgeSapkin
Could you please review this PR and let me know if there are any other problems that need improvement? Thank you.

Copy link
Member

@GeorgeSapkin GeorgeSapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message needs to follow the 50/75 rule as per the submissions guidelines and you need to use your real name both in author and sign-off.

Added logic to extract and match DNS record ID from parameters,
with fallback to default selection if no match is found.

Signed-off-by: QiLei Niu <[email protected]>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants