Add chip_name to temperature metric collection prometheus-node-exporter-lua/hwmon #28092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes duplicate sample with mt7996 and others with multiple radios
📦 Package Details
Maintainer: @champtar
Description:
Using the hwmon collector with a Banana Pi BPI-R4 there are duplicate samples for
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"}. This results in prometheus warnings:level=WARN source=scrape.go:1923 msg="Error on ingesting samples with different value but same timestamp" component="scrape manager" scrape_pool=node-exporter target=http://<ip>:9100/metrics num_dropped=2Adding the chip_name to node_hwmon_temp_celsius fixes this.
Current metrics:
Banana Pi BPI-R4
GL.iNet GL-MT6000
Fixed metrics:
Banana Pi BPI-R4
GL.iNet GL-MT6000
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.