Skip to content

Conversation

@vgropp
Copy link

@vgropp vgropp commented Dec 15, 2025

removes duplicate sample with mt7996 and others with multiple radios

📦 Package Details

Maintainer: @champtar

Description:
Using the hwmon collector with a Banana Pi BPI-R4 there are duplicate samples for node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"}. This results in prometheus warnings:
level=WARN source=scrape.go:1923 msg="Error on ingesting samples with different value but same timestamp" component="scrape manager" scrape_pool=node-exporter target=http://<ip>:9100/metrics num_dropped=2

Adding the chip_name to node_hwmon_temp_celsius fixes this.

Current metrics:
Banana Pi BPI-R4

node_hwmon_chip_names{chip_name="mt7996_phy0.0",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"} 49
node_hwmon_chip_names{chip_name="mt7996_phy0.1",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"} 49
node_hwmon_chip_names{chip_name="mt7996_phy0.2",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"} 51

GL.iNet GL-MT6000

node_hwmon_chip_names{chip_name="cpu_thermal",chip="thermal_thermal_zone0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="thermal_thermal_zone0"} 45.499
node_hwmon_chip_names{chip_name="mdio_bus:01",chip="mdio-bus_mdio-bus:01"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="mdio-bus_mdio-bus:01"} 52
node_hwmon_chip_names{chip_name="mdio_bus:07",chip="mdio-bus_mdio-bus:07"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="mdio-bus_mdio-bus:07"} 64
node_hwmon_chip_names{chip_name="mt7915_phy0",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"} 49
node_hwmon_chip_names{chip_name="mt7915_phy1",chip="ieee80211_phy1"} 1
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy1"} 49

Fixed metrics:
Banana Pi BPI-R4

node_hwmon_chip_names{chip_name="mt7996_phy0.0",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mt7996_phy0.0",chip="ieee80211_phy0"} 55
node_hwmon_chip_names{chip_name="mt7996_phy0.1",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mt7996_phy0.1",chip="ieee80211_phy0"} 55
node_hwmon_chip_names{chip_name="mt7996_phy0.2",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mt7996_phy0.2",chip="ieee80211_phy0"} 55

GL.iNet GL-MT6000

node_hwmon_chip_names{chip_name="cpu_thermal",chip="thermal_thermal_zone0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="cpu_thermal",chip="thermal_thermal_zone0"} 45.499
node_hwmon_chip_names{chip_name="mdio_bus:01",chip="mdio-bus_mdio-bus:01"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mdio_bus:01",chip="mdio-bus_mdio-bus:01"} 52
node_hwmon_chip_names{chip_name="mdio_bus:07",chip="mdio-bus_mdio-bus:07"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mdio_bus:07",chip="mdio-bus_mdio-bus:07"} 64
node_hwmon_chip_names{chip_name="mt7915_phy0",chip="ieee80211_phy0"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mt7915_phy0",chip="ieee80211_phy0"} 49
node_hwmon_chip_names{chip_name="mt7915_phy1",chip="ieee80211_phy1"} 1
node_hwmon_temp_celsius{sensor="temp1",chip_name="mt7915_phy1",chip="ieee80211_phy1"} 48

🧪 Run Testing Details

  • OpenWrt Version: OpenWrt SNAPSHOT r32316
  • OpenWrt Target/Subtarget: mediatek/filogic
  • OpenWrt Device: Banana Pi BPI-R4, GL.iNet GL-MT6000

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@GeorgeSapkin
Copy link
Member

The commit message needs to be prefixed with a package name and follow the 50/75 rule as per the submissions guidelines. And the package needs a PKG_RELEASE bump.

@vgropp
Copy link
Author

vgropp commented Dec 15, 2025

sorry for not following guidelines, i hope its fine now

adds chip_name to temp metrics to remove
duplicate sample with mt7996

Signed-off-by: Volker Gropp <[email protected]>
@vgropp
Copy link
Author

vgropp commented Dec 16, 2025

ok, i have no clue at all about these build failures. I can see libcurl recursive dependency and other errors but i dont understand why the build is failing by a change in the .lua script. I hope ill find more time to debug the full build process the next days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants