ddns-scripts: add namesilo.com #28095
Open
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You need to add a commit message, and use your real name both for author and sign-off, which is missing as per the contributing guidelines. |
GeorgeSapkin
requested changes
Dec 16, 2025
Member
GeorgeSapkin
left a comment
GeorgeSapkin
left a comment
There was a problem hiding this comment.
And you need to bump the PKG_RELEASE in the Makefile.
net/ddns-scripts/Makefile
Outdated
Comment on lines
138
to
139
|
|
||
|
|
net/ddns-scripts/Makefile
Outdated
Comment on lines
594
to
595
|
|
||
|
|
| @@ -0,0 +1,28 @@ | |||
| # | |||
| #.Distributed under the terms of the GNU General Public License (GPL) version 2.0 | |||
Member
There was a problem hiding this comment.
Consider using a SPDX license identifier instead.
| } | ||
|
|
||
| # update subdomain record | ||
| rrid=`call_api dnsListRecords "domain=$domain" | get_rrid` |
Member
There was a problem hiding this comment.
Suggested change
| rrid=`call_api dnsListRecords "domain=$domain" | get_rrid` | |
| rrid=$(call_api dnsListRecords "domain=$domain" | get_rrid) |
Comment on lines
24
to
26
| call_api dnsUpdateRecord "domain=$domain&rrid=$rrid&rrhost=$username&rrvalue=$__IP&rrttl=$__TTL" | grep success && { | ||
| return 0 | ||
| } |
Member
There was a problem hiding this comment.
Did you mean:
Suggested change
| call_api dnsUpdateRecord "domain=$domain&rrid=$rrid&rrhost=$username&rrvalue=$__IP&rrttl=$__TTL" | grep success && { | |
| return 0 | |
| } | |
| call_api dnsUpdateRecord "domain=$domain&rrid=$rrid&rrhost=$username&rrvalue=$__IP&rrttl=$__TTL" | grep success && true |
Author
|
Updated with all suggestions. |
Member
|
You still need to add a commit message with a description of the changes, besides the subject. |
cdfmr
force-pushed
the
ddns-namesilo
branch
3 times, most recently
from
530a7ff to
b142d07
Compare
GeorgeSapkin
requested changes
Dec 19, 2025
| @@ -0,0 +1,24 @@ | |||
| # | |||
| # SPDX-License-Identifier: GPL-2.0 | |||
Member
There was a problem hiding this comment.
There's no such identifier. Did you mean GPL-2.0-only?
Author
There was a problem hiding this comment.
Yes, should I update the file and re-commit?
new service provider namesilo.com config guide: * set [domain] to apex domain * set [username] to subdomain (without apex domain) * set [password] to api key Signed-off-by: Lin Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @
Description:
Add namesilo.com API to ddns-scripts package.
🧪 Run Testing Details
✅ Formalities