ddns-scripts: add beget.com api support

[LogExE]

📦 Package Details

Maintainer: @feckert (?)

Description:

This PR adds support for changing DNS records through beget.com API.

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The variable __CHANGE_ENDPOINT_API is declared as local at the script's top level, which is outside any function. In shell scripts, local is only meaningful inside functions. This should be declared without the local keyword, similar to how other DDNS update scripts handle their variables at the top level.

Suggested change

	local __CHANGE_ENDPOINT_API="https://api.beget.com/api/dns/changeRecords"
	local __RRTYPE
	local __STATUS
	__CHANGE_ENDPOINT_API="https://api.beget.com/api/dns/changeRecords"
	__RRTYPE
	__STATUS

[Copilot]

The variables __RRTYPE and __STATUS are declared as local at the script's top level, which is outside any function. In shell scripts, local is only meaningful inside functions. These should be declared without the local keyword, similar to how other DDNS update scripts handle their variables at the top level.

Suggested change

	local __CHANGE_ENDPOINT_API="https://api.beget.com/api/dns/changeRecords"
	local __RRTYPE
	local __STATUS
	__CHANGE_ENDPOINT_API="https://api.beget.com/api/dns/changeRecords"
	__RRTYPE=
	__STATUS=

[Copilot]

The script does not check the curl exit code or HTTP status code returned from the API. Unlike other DDNS update scripts (e.g., update_gandi_net.sh, update_digitalocean_com_v2.sh), there's no validation that the API call succeeded. The script should check if curl failed and validate that the HTTP status code indicates success before returning 0. Without this validation, DNS update failures may go undetected.

Suggested change

	-w "%{http_code}\n" \
	-o $DATFILE 2>$ERRFILE)
	write_log 7 "Beget API curl response: $(cat $DATFILE)"
	-w "%{http_code}" \
	-o "$DATFILE" 2>"$ERRFILE")
	__CURL_RC=$?
	write_log 7 "Beget API curl response: $(cat $DATFILE)"
	if [ "$__CURL_RC" -ne 0 ]; then
	write_log 3 "Beget API curl request failed with exit code $__CURL_RC"
	return 1
	fi
	case "$__STATUS" in
	2??)
	# HTTP 2xx, consider this a success
	;;
	*)
	write_log 3 "Beget API returned HTTP error code $__STATUS"
	return 1
	;;
	esac

[Copilot]

This line contains inconsistent indentation - it uses spaces instead of tabs. The rest of the Makefile uses tabs for indentation. This line should use a tab character at the beginning to match the surrounding code style.

Suggested change

	rm $(1)/usr/share/ddns/default/beget.com.json
	rm $(1)/usr/share/ddns/default/beget.com.json

[Copilot]

There is trailing whitespace at the end of this line. This should be removed to maintain code cleanliness and consistency with the rest of the codebase.

Suggested change

[Copilot]

The priority field is hardcoded to 10. According to DNS standards, priority is typically only relevant for MX (mail exchange) and SRV (service) records, not for A or AAAA records which are being set here. This field may be unnecessary or could cause API errors. Verify if the Beget API requires or accepts a priority field for A/AAAA records, and if not, this field should be removed.

Suggested change

json_add_int "priority" 10

[GeorgeSapkin]

On top of all the other suggestions, you need to add a commit message describing the changes and use your real name both as author and sign-off.