unbound: prevent reloading local-data every 5 minutes for unchanged records in odhcpd.sh (longtime) #28111
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecords in odhcpd.sh (longtime) The default longtime handler (every 5 minutes) dumps the full lease list, causing Unbound to reload all local-data records even when nothing changed. This creates periodic CPU/RSS spikes and increases memory fragmentation, increasing the chance of earlyoom killing Unbound on low-memory devices (i.e., on most devices running openwrt) This patch adds a small pipeline (tr | sed | grep | sed) to filter out unchanged lease entries, so only true deltas are sent to Unbound via local_datas / local_datas_remove. - No change to real-time lease updates. - Fail-safe: if filtering fails, falls back to stock full reload. - Preserves original record ordering. - Works with busybox or GNU versions of tr, sed, grep, sort, uniq - Tested on IPQ8074 (dynalink dl-wrx36) with NSS + SQM + Unbound + odhcpd + large adblock list. Signed-off-by: Anthony Barone <[email protected]> Signed-off-by: Anthony <[email protected]>
Made sed filter that identifies PTR lines more robust Signed-off-by: Anthony <[email protected]>
Member
|
You need to format your commit message according to 50/75 rule, bump |
Contributor
|
... and please change/inform the unbound maintainer @EricLuehrsen ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @EricLuehrsen, @dibdot
Description: modifies the "longtime" method in odhcpd.sh so that DHCP leases that appear identically on both the "del" and "add" lists are removed from both lists and are not unloaded then immediately reloaded via unbound-control
The default longtime handler dumps and reloads the full lease list every 5 minutes, causing Unbound to reload all local-data records even when nothing changed. This creates periodic CPU/RSS spikes and increases memory fragmentation, increasing the chance of earlyoom killing Unbound on low-memory devices (i.e., on most devices running openwrt). This can leave the router unable to resolve DNS queries or hand out DHCP leases until the unbound service is manually restarted.
This patch adds a small pipeline (tr | sed | grep | sed) to filter out unchanged lease entries, so only true deltas are sent to Unbound via local_datas / local_datas_remove. Filtering is done using grouped local-data + local-data-ptr pairs. When there are no changes to any DHCP leases from the last 5 minutes, unbound-control is not called at all. This is implemented so that:
🧪 Run Testing Details
✅ Formalities
Signed-off-by: Anthony Barone [email protected]