watchcat: fix ping argument bug, add enabled option #28116
+19
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors like that: > Could not reach "77.88.8.8 for 66. Rebooting after reaching 21600 Run with `sh -x`, i got: ``` + ping standard -I any -s 300 -c 1 '"77.88.8.8' ``` Which is caused by bad variable masking. Also added `enabled` option to selectively disable sections. Signed-off-by: Vladimir Ermakov <[email protected]>
vooon
referenced
this pull request
Dec 19, 2025
The backend now correctly supports multiple IP addresses and avoids argument shifting when mmifacename is empty. Signed-off-by: Ivan Diaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: Roger D [email protected]
Description:
Fix errors like that:
Run with
sh -x, i got:Which is caused by bad variable masking.
That also reported here: 5dc1390#comments
Also added
enabledoption to selectively disable sectionsand connected stdio to log, to easify debugging with
set -x.🧪 Run Testing Details
✅ Formalities