Parameterize elemental_ir_emitter_test.cc float tests #17383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedwm
requested changes
Sep 20, 2024
| tsl::float8_e4m3b11fnuz, tsl::float8_e5m2, | ||
| tsl::float8_e5m2fnuz>; | ||
|
|
||
| TYPED_TEST_SUITE(ElementalIrEmitterExecutionTypedTest, FloatTypes); |
There was a problem hiding this comment.
Since we only use the type name, not the actual C++ type, this can be a value-parameterized test (with TEST_P) instead of a type-parameterized test (with TYPED_TEST)
There was a problem hiding this comment.
I initially attempted that approach, but I realized the CompareFloat test requires TypeParam (used in LiteralUtil::CreateR1<TypeParam>) to execute RunTest with a Span of Literals of the specified type. Therefore, I refactored the original implementation using TYPED_TEST_SUITE.
reedwm
approved these changes
Sep 20, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR #17383 `elemental_ir_emitter_test.cc` contains multiple similar tests for `bf16`, `f8e4m3fnuz` and , `f8e5m2fnuz`. Changes: - Parameterize the float tests in elemental_ir_emitter_test.cc. - Add additional types to the list of tested types - `f8e5m2`, `f8e4m3fn`, `f8e4m3b11fnuz`. Some tests failed for newly added types. Temporary use `GTEST_SKIP` for such cases: Related issues: - #17323 - #17324 Copybara import of the project: -- 47dcfcf by Alexander Pivovarov <[email protected]>: Parameterize elemental_ir_emitter_test.cc float tests Merging this change closes #17383 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17383 from apivovarov:param_elemental_ir_emitter_test 47dcfcf PiperOrigin-RevId: 676627549
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR openxla/xla#17383 `elemental_ir_emitter_test.cc` contains multiple similar tests for `bf16`, `f8e4m3fnuz` and , `f8e5m2fnuz`. Changes: - Parameterize the float tests in elemental_ir_emitter_test.cc. - Add additional types to the list of tested types - `f8e5m2`, `f8e4m3fn`, `f8e4m3b11fnuz`. Some tests failed for newly added types. Temporary use `GTEST_SKIP` for such cases: Related issues: - openxla/xla#17323 - openxla/xla#17324 Copybara import of the project: -- 47dcfcf43908584d453f63008c9d68b5e7dae9c3 by Alexander Pivovarov <[email protected]>: Parameterize elemental_ir_emitter_test.cc float tests Merging this change closes #17383 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17383 from apivovarov:param_elemental_ir_emitter_test 47dcfcf43908584d453f63008c9d68b5e7dae9c3 PiperOrigin-RevId: 676627549
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR #17383 `elemental_ir_emitter_test.cc` contains multiple similar tests for `bf16`, `f8e4m3fnuz` and , `f8e5m2fnuz`. Changes: - Parameterize the float tests in elemental_ir_emitter_test.cc. - Add additional types to the list of tested types - `f8e5m2`, `f8e4m3fn`, `f8e4m3b11fnuz`. Some tests failed for newly added types. Temporary use `GTEST_SKIP` for such cases: Related issues: - #17323 - #17324 Copybara import of the project: -- 47dcfcf by Alexander Pivovarov <[email protected]>: Parameterize elemental_ir_emitter_test.cc float tests Merging this change closes #17383 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17383 from apivovarov:param_elemental_ir_emitter_test 47dcfcf PiperOrigin-RevId: 676627549
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 20, 2024
Imported from GitHub PR openxla/xla#17383 `elemental_ir_emitter_test.cc` contains multiple similar tests for `bf16`, `f8e4m3fnuz` and , `f8e5m2fnuz`. Changes: - Parameterize the float tests in elemental_ir_emitter_test.cc. - Add additional types to the list of tested types - `f8e5m2`, `f8e4m3fn`, `f8e4m3b11fnuz`. Some tests failed for newly added types. Temporary use `GTEST_SKIP` for such cases: Related issues: - openxla/xla#17323 - openxla/xla#17324 Copybara import of the project: -- 47dcfcf43908584d453f63008c9d68b5e7dae9c3 by Alexander Pivovarov <[email protected]>: Parameterize elemental_ir_emitter_test.cc float tests Merging this change closes #17383 PiperOrigin-RevId: 676739814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elemental_ir_emitter_test.cccontains multiple similar tests forbf16,f8e4m3fnuzand ,f8e5m2fnuz.Changes:
f8e5m2,f8e4m3fn,f8e4m3b11fnuz.Some tests failed for newly added types. Temporary use
GTEST_SKIPfor such cases:Related issues: