Skip to content

Create a PjRt protos dir. #24690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Create a PjRt protos dir. #24690

merged 1 commit into from
May 15, 2025

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Apr 4, 2025

Create a PjRt protos dir.

This dir exists for common PjRt proto files. To avoid breaking Jax in OSS, we also create an empty forwarding header & BUILD target where the old compile_options.proto used to live, which will soon be deleted.

We only move the protos in third_party/tensorflow/compiler/xla/pjrt into this new dir (i.e. don't include pjrt/stream_executor_executable.proto, pjrt/distributed/protocol.proto, pjrt/gpu/gpu_topology.proto, and pjrt/plugin/xla_cpu/cpu_topology.proto) since those are purpose specific.

@copybara-service copybara-service bot force-pushed the test_742896659 branch 2 times, most recently from e752d7a to 49aa9fb Compare April 9, 2025 20:49
@copybara-service copybara-service bot force-pushed the test_742896659 branch 4 times, most recently from 89729b6 to a17f05e Compare April 17, 2025 01:09
@copybara-service copybara-service bot force-pushed the test_742896659 branch 2 times, most recently from 3884a4f to 889f35c Compare April 22, 2025 20:05
@copybara-service copybara-service bot force-pushed the test_742896659 branch 11 times, most recently from c4d568d to 582b9f1 Compare May 7, 2025 23:32
@copybara-service copybara-service bot force-pushed the test_742896659 branch 6 times, most recently from e387d1c to 7df7bd1 Compare May 15, 2025 21:34
This dir exists for common PjRt proto files. To avoid breaking Jax in OSS, we also create an empty forwarding header & BUILD target where the old `compile_options.proto` used to live, which will soon be deleted.

We only move the protos in `third_party/tensorflow/compiler/xla/pjrt` into this new dir (i.e. don't include `pjrt/stream_executor_executable.proto`, `pjrt/distributed/protocol.proto`, `pjrt/gpu/gpu_topology.proto`, and `pjrt/plugin/xla_cpu/cpu_topology.proto`) since those are purpose specific.

PiperOrigin-RevId: 759327203
@copybara-service copybara-service bot merged commit 4442e99 into main May 15, 2025
1 check passed
@copybara-service copybara-service bot deleted the test_742896659 branch May 15, 2025 22:35
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request May 29, 2025
copybara-service bot pushed a commit that referenced this pull request May 29, 2025
Follow up to #24690.

PiperOrigin-RevId: 764468711
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 29, 2025
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request May 29, 2025
copybara-service bot pushed a commit that referenced this pull request May 29, 2025
Follow up to #24690.

PiperOrigin-RevId: 764468711
copybara-service bot pushed a commit to jax-ml/jax that referenced this pull request May 29, 2025
copybara-service bot pushed a commit that referenced this pull request May 29, 2025
Follow up to #24690.

PiperOrigin-RevId: 764468711
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 29, 2025
copybara-service bot pushed a commit that referenced this pull request May 29, 2025
Follow up to #24690.

PiperOrigin-RevId: 764865964
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 29, 2025
charleshofer pushed a commit to ROCm/jax that referenced this pull request Jun 19, 2025
charleshofer pushed a commit to ROCm/xla that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant