-
Notifications
You must be signed in to change notification settings - Fork 609
Create a PjRt protos dir. #24690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Create a PjRt protos dir. #24690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e752d7a
to
49aa9fb
Compare
89729b6
to
a17f05e
Compare
3884a4f
to
889f35c
Compare
c4d568d
to
582b9f1
Compare
e387d1c
to
7df7bd1
Compare
This dir exists for common PjRt proto files. To avoid breaking Jax in OSS, we also create an empty forwarding header & BUILD target where the old `compile_options.proto` used to live, which will soon be deleted. We only move the protos in `third_party/tensorflow/compiler/xla/pjrt` into this new dir (i.e. don't include `pjrt/stream_executor_executable.proto`, `pjrt/distributed/protocol.proto`, `pjrt/gpu/gpu_topology.proto`, and `pjrt/plugin/xla_cpu/cpu_topology.proto`) since those are purpose specific. PiperOrigin-RevId: 759327203
7df7bd1
to
4442e99
Compare
copybara-service bot
pushed a commit
to jax-ml/jax
that referenced
this pull request
May 29, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764468709
copybara-service bot
pushed a commit
that referenced
this pull request
May 29, 2025
Follow up to #24690. PiperOrigin-RevId: 764468711
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 29, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764468711
copybara-service bot
pushed a commit
to jax-ml/jax
that referenced
this pull request
May 29, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764468709
copybara-service bot
pushed a commit
that referenced
this pull request
May 29, 2025
Follow up to #24690. PiperOrigin-RevId: 764468711
copybara-service bot
pushed a commit
to jax-ml/jax
that referenced
this pull request
May 29, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764802248
copybara-service bot
pushed a commit
that referenced
this pull request
May 29, 2025
Follow up to #24690. PiperOrigin-RevId: 764468711
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 29, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764468711
copybara-service bot
pushed a commit
that referenced
this pull request
May 29, 2025
Follow up to #24690. PiperOrigin-RevId: 764865964
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 29, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764865964
charleshofer
pushed a commit
to ROCm/jax
that referenced
this pull request
Jun 19, 2025
Follow up to openxla/xla#24690. PiperOrigin-RevId: 764802248
charleshofer
pushed a commit
to ROCm/xla
that referenced
this pull request
Jun 24, 2025
Follow up to openxla#24690. PiperOrigin-RevId: 764865964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a PjRt protos dir.
This dir exists for common PjRt proto files. To avoid breaking Jax in OSS, we also create an empty forwarding header & BUILD target where the old
compile_options.proto
used to live, which will soon be deleted.We only move the protos in
third_party/tensorflow/compiler/xla/pjrt
into this new dir (i.e. don't includepjrt/stream_executor_executable.proto
,pjrt/distributed/protocol.proto
,pjrt/gpu/gpu_topology.proto
, andpjrt/plugin/xla_cpu/cpu_topology.proto
) since those are purpose specific.