PR #25273: Move fusion-dispatch to RunBackend. #25276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_747850451
branch
2 times, most recently
from
fd08959 to
8e94a99
Compare
Imported from GitHub PR #25273 The intention is that this pass runs after all passes that can create or modify fusions. However, this is currently not the case, since there are a couple of passes in RunBackend that violate this condition. The tests didn't catch this because they only checked the passes in RunHloPasses, not the ones in RunBackend. Copybara import of the project: -- 9b09c79 by Johannes Reifferscheid <[email protected]>: Move fusion-dispatch to RunBackend. Currently, there are still a couple of passes that can create new fusions after fusion-dispatch. This should not happen. The tests didn't catch this because they only checked the passes in RunHloPasses, not the ones in RunBackend. -- d2365be by Johannes Reifferscheid <[email protected]>: Add more comments to the test. Merging this change closes #25273 COPYBARA_INTEGRATE_REVIEW=#25273 from jreiffers:move-fusion-dispatch d2365be PiperOrigin-RevId: 748462531
copybara-service
bot
force-pushed
the
test_747850451
branch
from
8e94a99 to
3b2ce68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #25273: Move fusion-dispatch to RunBackend.
Imported from GitHub PR #25273
The intention is that this pass runs after all passes that can create or modify fusions. However, this is currently not the case, since there are a couple of passes in RunBackend that violate this condition.
The tests didn't catch this because they only checked the passes in RunHloPasses, not the ones in RunBackend.
Copybara import of the project:
--
9b09c79 by Johannes Reifferscheid [email protected]:
Move fusion-dispatch to RunBackend.
Currently, there are still a couple of passes that can create
new fusions after fusion-dispatch. This should not happen.
The tests didn't catch this because they only checked the passes
in RunHloPasses, not the ones in RunBackend.
--
d2365be by Johannes Reifferscheid [email protected]:
Add more comments to the test.
Merging this change closes #25273
FUTURE_COPYBARA_INTEGRATE_REVIEW=#25273 from jreiffers:move-fusion-dispatch d2365be