Add an optional parameter to Shape::add_dimensions() in indicate whether the dimension is dynamic.
#25334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_748314466
branch
6 times, most recently
from
1dcbc2c to
608ba69
Compare
…ether the dimension is dynamic. Currently, `add_dimensions()` doesn't validate the dimension size and assumes that the dimension is static. This may result in a `Shape` object that doesn't match the author's intention or break the `Shape` object's invariants. E.g. - If the author wants a *dynamic* dimension of size 5, `add_dimensions(5)` will create a *static* dimension of size 5. The author must remember to immediately set the dimension to be dynamic. This is error-prone. - `add_dimensions(kUnboundedSize)` results in a *static* dimension of size `kUnboundedSize`, which is invalid. With the new `is_dynamic` parameter, callers can explicitly express their intention, and `add_dimensions()` can validate the arguments to increase safety. PiperOrigin-RevId: 748840578
copybara-service
bot
force-pushed
the
test_748314466
branch
from
608ba69 to
8f4e499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional parameter to
Shape::add_dimensions()in indicate whether the dimension is dynamic.Currently,
add_dimensions()doesn't validate the dimension size and assumes that the dimension is static. This may result in aShapeobject that doesn't match the author's intention or break theShapeobject's invariants. E.g.add_dimensions(5)will create a static dimension of size 5. The author must remember to immediately set the dimension to be dynamic. This is error-prone.add_dimensions(kUnboundedSize)results in a static dimension of sizekUnboundedSize, which is invalid.With the new
is_dynamicparameter, callers can explicitly express their intention, andadd_dimensions()can validate the arguments to increase safety.