Remove unsafe Shape::mutable_dynamic_dimensions().
#25341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Some combinations of (dimension_size, is_dynamic) are invalid (e.g. a static dimension cannot have a size = `kUnboundedSize`). To ensure that `Shape`'s invariants aren't broken, we shouldn't expose `dimensions` and `dynamic_dimensions` as mutable values directly. Instead, all changes to these properties should go through safe `Shape` APIs that validate the arguments (e.g. `set_dynamic_dimension()`). Luckily, `mutable_dynamic_dimensions()` is unused, so we can just remove it. PiperOrigin-RevId: 748540904
copybara-service
bot
force-pushed
the
test_748372224
branch
from
68b270e to
57e2700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unsafe
Shape::mutable_dynamic_dimensions().