jdbi3: converts to StatementLogger and follows existing style #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
May 28, 2025
instrumentation/jdbi3/src/main/java/brave/jdbi3/TracingSqlLogger.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Adrian Cole <[email protected]>
|
@reta if you don't mind, please handle any follow-ups and/or cut the next brave when ready.! |
Will do, thanks a lot @codefromthecrypt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts jdbi3 instrumentation to be more like MongoDB in implementation: configured by instance, not static like mysql connection driver. It also pares back the data policy to be the same as MySQL: this allows us a base case to move forward with. Finally, it switches implementation to a StatementLogger, so that exceptions are visible.
Infrastructure wise, this re-uses the more recent style from instrumentation here, including docker for the IT.
This is a follow-up to #1460 before we release a version, so API breaks are not an issue, yet.
Thanks to @reftel for the initial work on this, and @reta on the review of that. I did my best in RATIONALE.md here to explain why the changes are important.