fix #64 adds settable check functions for cert/serverCert #65
Conversation
| @@ -76,9 +76,15 @@ type Identity interface { | |||
| // StopWatchingFiles reversed WatchFiles. | |||
| StopWatchingFiles() | |||
|
|
|||
| // IsCertSettable returns nil if the "cert" certificate storage supports writing, used before calling SetCert() | |||
| IsCertSettable() error | |||
There was a problem hiding this comment.
imo, it seems strange for an 'Is' function to return error not a bool
There was a problem hiding this comment.
It is a go thing because errors are returned, not raised.
Consider this set of outcomes: for (bool,error) function return values:
1: true, <nil>
2: false, err
3: false, <nil>
It forces the caller to inspect two values instead of 1. By returning error only, they only have to inspect 1. Additionally, nothing stops the code from returning true, error and in which case, what does that mean?
Returning just bool doesn't allow error propagation for other issues.
There was a problem hiding this comment.
:D if you say so. I'd just prefer the "Is" to be "Verify" or "Check" or literally anything that isn't "Is" but i don't care all that much
- workflows updated to ref go.mod for go version and update modules used - go 1.23 selected as it is the minimum version currently supported w/o compat issues with the SDK
Done to support openziti/ziti#2984