Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change flag for config file to "-c,--config" #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change flag for config file to "-c,--config" #79

wants to merge 2 commits into from

Conversation

ohaiwalt
Copy link
Member

@ohaiwalt ohaiwalt commented Aug 18, 2017 •
edited
Loading

Breaking change for anyone who may be specifying their relay config file from the command line.

$ ./relay --help
Usage of ./relay:
  -c, --config string       Path to configuration file
      --cpuprofile string   Write CPU profile to file
      --dev                 Enable developer mode
      --memprofile string   Write memory profile to this file

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/operable/go-relay/pulls/79.

@ohaiwalt
Copy link
Member Author

Fixes #76

@coveralls
Copy link

Coverage Status

Coverage remained the same at 20.893% when pulling ab7bec1 on ohaiwalt/config-flag into 858b8ff on master.

@agis
Copy link
Member

agis commented Aug 18, 2017 •
edited
Loading

I'm curious, what's the argument for breaking backwards compatibility by changing the flags?

P.S. This is more of a question to @vanstee who created the original issue (operable/cog#628).

jesselang
jesselang reviewed Oct 17, 2017
View reviewed changes
main.go
@@ -20,10 +20,10 @@ const (
BUS_ERR
)

var configFile = flag.String("file", "", "Path to configuration file")
var configFile = flag.StringP("config", "c", "", "Path to configuration file")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep compatibility and deprecate out --file with a warning instead of a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesselang jesselang jesselang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohaiwalt @coveralls @agis @jesselang