feat: optional dependent resource #2240

csviri · 2024-02-13T10:43:24Z

No description provided.

csviri · 2024-03-06T15:04:36Z

For customizing the expiration mechanism there will be a separate PR.

...n/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DefaultManagedWorkflow.java

metacosm · 2024-03-12T12:57:57Z

...amework-core/src/main/java/io/javaoperatorsdk/operator/processing/expiration/Expiration.java

+package io.javaoperatorsdk.operator.processing.expiration;
+
+
+public interface Expiration {


Why do we need an interface for this? Do we envision multiple implementations?

This is same principle as for retry, some might be able different strategy, so created an abstraction for that.

metacosm · 2024-03-12T12:58:12Z

...ore/src/main/java/io/javaoperatorsdk/operator/processing/expiration/ExpirationExecution.java

@@ -0,0 +1,9 @@
+package io.javaoperatorsdk.operator.processing.expiration;
+
+public interface ExpirationExecution {


Same comment than for Expiration.

metacosm · 2024-03-12T13:02:56Z

...io/javaoperatorsdk/operator/processing/dependent/workflow/CRDPresentActivationCondition.java

+import io.javaoperatorsdk.operator.processing.retry.GenericRetry;
+import io.javaoperatorsdk.operator.processing.retry.Retry;
+
+public class CRDPresentActivationCondition implements Condition<HasMetadata, HasMetadata> {


I think this should be better implemented as a utilty class that could be reused elsewhere and shared across reconcilers, in particular because Controller also can check the availability of the CRD so it would be better if the same logic / implementation / cache could be reused/shared everywhere this functionality is needed.

Yes, that is true, I don't like utilities / static scoped states, usually, those lead to problems (eventually). But will think about how to handle that.

Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]>

…2331) Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]>

* improve: ensure unique name on event sources Signed-off-by: Attila Mészáros <[email protected]> * fix Signed-off-by: Attila Mészáros <[email protected]> --------- Signed-off-by: Attila Mészáros <[email protected]>

Signed-off-by: Attila Mészáros <[email protected]>

openshift-merge-robot · 2024-06-17T16:20:16Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

csviri self-assigned this Feb 13, 2024

csviri linked an issue Feb 13, 2024 that may be closed by this pull request

Support for optional @Dependent resources #2238

Closed

csviri force-pushed the optional-dependent branch from 8c0b66b to a308146 Compare March 6, 2024 09:50

csviri marked this pull request as ready for review March 6, 2024 14:32

openshift-ci bot requested review from adam-sandor and andreaTP March 6, 2024 14:32

csviri requested a review from metacosm March 6, 2024 15:05

csviri force-pushed the next branch from f2be686 to c281903 Compare March 7, 2024 10:48

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024

csviri force-pushed the next branch from e0a622f to c67ca26 Compare March 11, 2024 19:19

csviri force-pushed the optional-dependent branch from 17004b3 to cdce182 Compare March 12, 2024 09:18

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024

metacosm requested changes Mar 12, 2024

View reviewed changes

csviri force-pushed the optional-dependent branch from cdce182 to 422224d Compare March 19, 2024 07:34

csviri force-pushed the optional-dependent branch from 422224d to daf2262 Compare March 26, 2024 14:19

csviri force-pushed the next branch from 5061759 to 9942cda Compare April 10, 2024 13:58

metacosm force-pushed the next branch from 6a83ecf to d7da94e Compare April 10, 2024 14:27

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024

metacosm force-pushed the next branch from d7da94e to 76046f7 Compare April 11, 2024 14:50

csviri force-pushed the next branch 2 times, most recently from 88c4960 to afe3d7d Compare May 17, 2024 10:46

csviri and others added 8 commits May 21, 2024 21:02

chore: set version to 5.0.0-SNAPSHOT (#2200)

a1235bc

Signed-off-by: Attila Mészáros <[email protected]>

improve: java version minimal 11, tested on 21 (#2207)

0463ce7

Signed-off-by: Attila Mészáros <[email protected]>

improve: remove deprecated EventFilter (#2208)

ff2bbfa

Signed-off-by: Attila Mészáros <[email protected]>

docs: 5.0 migration guide skeleton (#2210)

9eb3fac

Signed-off-by: Attila Mészáros <[email protected]>

improve: managed dependent reconciliation results not optional (#2212)

c0a741c

Signed-off-by: Attila Mészáros <[email protected]>

improve: remove deprecated RetryConfiguration (#2211)

76bbc6c

Signed-off-by: Attila Mészáros <[email protected]>

feat: JDK client is now the default (#2235)

1df8a80

Signed-off-by: Attila Mészáros <[email protected]>

fix: update SCM information (#2237)

2389cda

Signed-off-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

csviri and others added 18 commits May 21, 2024 21:02

fix: format after rebase

c096f87

Signed-off-by: Attila Mészáros <[email protected]>

fix: remove now unneeded okhttp dependency override, wrong comment (#…

1ada74d

…2331) Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

feat: run spotless on compile (#2330)

37dbf1f

Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

refactor: clean-up (#2325)

d3a15e4

Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

improve: samples correctly create status object for SSA (#2365)

599dd46

Signed-off-by: Attila Mészáros <[email protected]>

improve: named event sources and related changes (#2340)

1e56113

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

feat: silent exception handling in managed workflows (#2363)

16bb1b3

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

feat: feature flag to not clone secondary resource on access (#2364)

486c750

Signed-off-by: Attila Mészáros <[email protected]>

fix: unit test for event processor stopping (#2373)

f036f86

Signed-off-by: Attila Mészáros <[email protected]>

feat: all event source is resource event source (#2367)

27ca97c

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

feat: read-only bulk dependent (#2372)

fa2f06a

Signed-off-by: Attila Mészáros <[email protected]>

feat: remove automatic observed generation handling (#2382)

9acfda6

Signed-off-by: Attila Mészáros <[email protected]> Signed-off-by: Chris Laprun <[email protected]> Co-authored-by: Chris Laprun <[email protected]> Signed-off-by: Attila Mészáros <[email protected]>

docs: bulk dependent resource migration (#2383)

dc4dc90

Signed-off-by: Attila Mészáros <[email protected]>

fix: correct default secondary to primary mapper (#2386)

04febbd

Signed-off-by: Attila Mészáros <[email protected]>

improve: secondaryToPrimary check type of owner reference (#2371)

463ee73

Signed-off-by: Attila Mészáros <[email protected]>

improve: remove deprecated APIs (#2375)

9119c59

Signed-off-by: Attila Mészáros <[email protected]>

improve: ensure unique name on event sources (#2370)

78b0586

* improve: ensure unique name on event sources Signed-off-by: Attila Mészáros <[email protected]> * fix Signed-off-by: Attila Mészáros <[email protected]> --------- Signed-off-by: Attila Mészáros <[email protected]>

fix: pom formatting

cc57156

Signed-off-by: Attila Mészáros <[email protected]>

csviri force-pushed the next branch from afe3d7d to cc57156 Compare May 21, 2024 19:03

csviri added 4 commits May 21, 2024 23:22

docs: migrate v5 changes to docsy (#2397)

5337e79

Signed-off-by: Attila Mészáros <[email protected]>

docs: @workflow usage (#2413)

4105421

Signed-off-by: Attila Mészáros <[email protected]>

feat: API to check if next reconciliation is imminent (#2272)

705c9b1

Signed-off-by: Attila Mészáros <[email protected]>

feat: optional dependent

2d22dd2

csviri force-pushed the optional-dependent branch from 7f97e23 to 2d22dd2 Compare June 13, 2024 07:26

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024

fix

405d64a

Signed-off-by: Attila Mészáros <[email protected]>

csviri force-pushed the next branch from c1f2db7 to d538711 Compare June 17, 2024 09:34

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024

csviri closed this Jun 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: optional dependent resource #2240

feat: optional dependent resource #2240

csviri commented Feb 13, 2024

csviri commented Mar 6, 2024

metacosm Mar 12, 2024

csviri Mar 12, 2024

metacosm Mar 12, 2024

metacosm Mar 12, 2024

csviri Mar 12, 2024

openshift-merge-robot commented Jun 17, 2024

		package io.javaoperatorsdk.operator.processing.expiration;


		public interface Expiration {

		@@ -0,0 +1,9 @@
		package io.javaoperatorsdk.operator.processing.expiration;

		public interface ExpirationExecution {

feat: optional dependent resource #2240

feat: optional dependent resource #2240

Conversation

csviri commented Feb 13, 2024

csviri commented Mar 6, 2024

metacosm Mar 12, 2024

Choose a reason for hiding this comment

csviri Mar 12, 2024

Choose a reason for hiding this comment

metacosm Mar 12, 2024

Choose a reason for hiding this comment

metacosm Mar 12, 2024

Choose a reason for hiding this comment

csviri Mar 12, 2024

Choose a reason for hiding this comment

openshift-merge-robot commented Jun 17, 2024