improve: replace jenvtest with kube-api-test from fabric8 client #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
csviri
changed the title
openshift-merge-robot
removed
the
needs-rebase
metacosm
reviewed
Aug 14, 2024
| @@ -85,9 +85,8 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.javaoperatorsdk</groupId> | |||
| <artifactId>jenvtest</artifactId> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
Shouldn't it still use the test scope?
There was a problem hiding this comment.
I guess that is inherited from dependency management
There was a problem hiding this comment.
https://stackoverflow.com/questions/15221299/dependencymanagement-and-scope seems to indicate that putting scopes in dependencyManagement is a bad practice…
There was a problem hiding this comment.
hmm, ok np, will move it
metacosm
approved these changes
Aug 14, 2024
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
use-kube-api-test
branch
from
23ed3b7 to
9492575
Compare
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
approved these changes
Aug 15, 2024
metacosm
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 19, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Attila Mészáros <[email protected]>
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.