remove bundle injection, make golangci-lint config consistent #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
consistent-golangci-lint-config
branch
from
001bb62 to
a6286fb
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to make the golangci-lint config consistent across repo.
One issue that turned up was around complexity with some code related to injecting bundles via the old sqlite dynamic pod injection technique. Rather than spending the time making that code less complex, I removed it. That's because we've moved on to FBC catalogs and that code is obsolete. It's flags have also always been hidden, so there is little risk of breakage.