Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Test fix e2e #1354

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

rashmi43
Copy link
Contributor

@rashmi43 rashmi43 commented Oct 8, 2024

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@rashmi43 rashmi43 requested a review from a team as a code owner October 8, 2024 17:37
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit bec7d35
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6708156bcb306a0008e33fe2
😎 Deploy Preview https://deploy-preview-1354--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort changed the title :bug Test fix e2e 🐛 Test fix e2e Oct 8, 2024
@m1kola
Copy link
Member

m1kola commented Oct 28, 2024

@rashmi43 could you please add details to the commit message & PR description? What is this for? What are we solving?

Also could you please rebase the branch - I see 8 commits here and it looks like most of them are not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants