OCPBUGS-17157: improve watching semantics around CSVs #3003
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Depends on operator-framework/api#289 |
stevekuznetsov
force-pushed
the
skuznets/catalog-operator-csv
branch
3 times, most recently
from
8d1fb74
to
9c2ec9c
Compare
stevekuznetsov
force-pushed
the
skuznets/catalog-operator-csv
branch
3 times, most recently
from
e7821f3
to
ef9f9a3
Compare
There was a problem hiding this comment.
Nice one! Thank you ^^
We have a downstream only plug-in that creates a copiedcsv informer - do you think we'd benefit with this change there as well?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@perdasilva interesting! Yeah, I'll get that when I downstream this, thanks for the call-out. |
As far as I can tell, we never do anything with them. Signed-off-by: Steve Kuznetsov <[email protected]>
All we ever ned to know about copied CSVs is their metadata. No need to prune objects in memory, it's better to never allocate the memory to deserilize them in the first place. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/catalog-operator-csv
branch
from
ef9f9a3
to
fc29ea1
Compare
|
/lgtm |
|
@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
operators/olm: use a partial object metadata watch for copied CSVs
All we ever ned to know about copied CSVs is their metadata. No need to
prune objects in memory, it's better to never allocate the memory to
deserilize them in the first place.
Signed-off-by: Steve Kuznetsov [email protected]
operators/catalog: don't watch copied CSVs
As far as I can tell, we never do anything with them.
Signed-off-by: Steve Kuznetsov [email protected]