Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging around catalog source sync #3414

Merged

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented Oct 18, 2024

Description of the change:

A recent live debugging session revealed that the catalog source reconciliation loop is under logged. This PR adds more logging. Generally, I've tried to:

  • log start and end of method calls
  • log errors as close as possible to source
  • call out steps in the methods

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@perdasilva perdasilva force-pushed the perdasilva/catsrc/logging branch 3 times, most recently from a5ec49a to e13881e Compare October 18, 2024 11:26
@perdasilva perdasilva force-pushed the perdasilva/catsrc/logging branch from d6c2abb to b48b163 Compare October 18, 2024 16:22
@perdasilva perdasilva force-pushed the perdasilva/catsrc/logging branch 6 times, most recently from dad1e2a to 576ea51 Compare December 20, 2024 15:36
@perdasilva perdasilva force-pushed the perdasilva/catsrc/logging branch 2 times, most recently from 6390a9c to 42126d6 Compare January 13, 2025 12:20
@perdasilva perdasilva force-pushed the perdasilva/catsrc/logging branch from 42126d6 to 0b34467 Compare January 14, 2025 11:09
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/catsrc/logging branch from 0b34467 to 900889f Compare January 14, 2025 11:19
@perdasilva perdasilva enabled auto-merge January 14, 2025 17:36
@perdasilva perdasilva added this pull request to the merge queue Jan 16, 2025
Merged via the queue into operator-framework:master with commit 4043bab Jan 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants