Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide an optional base image flag for generated dockerfiles from alpha bundle build commands #1519

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Dec 12, 2024

Description of the change:
This PR adds an optional "base-image" flag to opm alpha bundle generate. This results in some breaking changes for possible clients which now must pass a new parameter "scratch" to produce previous behavior.

Motivation for the change:
Some clients prefer to use base images other than scratch. This is the lightest-touch approach I could use to provide this.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@grokspawn grokspawn force-pushed the custom-bundle-build-base-image branch from fe99e6f to f6cf01e Compare December 12, 2024 21:45
@grokspawn grokspawn requested a review from joelanford December 12, 2024 21:50
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.80%. Comparing base (dc23843) to head (f6cf01e).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
pkg/lib/bundle/build.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   48.61%   46.80%   -1.82%     
==========================================
  Files         135      135              
  Lines       12793    15760    +2967     
==========================================
+ Hits         6219     7376    +1157     
- Misses       5533     7343    +1810     
  Partials     1041     1041              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn changed the title provide an optional base image flag for generated dockerfiles from bundle build commands provide an optional base image flag for generated dockerfiles from alpha bundle build commands Dec 16, 2024
@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 03156cf into operator-framework:master Dec 17, 2024
10 of 12 checks passed
@grokspawn grokspawn deleted the custom-bundle-build-base-image branch December 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants