-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump go version to 1.23 #11
Conversation
Signed-off-by: Artur Zych <[email protected]>
I am ok with, but for we update operator-controller and etc to use go 1.23 we need bump the next/future release of controller-runtime: https://github.com/kubernetes-sigs/controller-runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm cancel I want to approve to run the tests and not get it merged now |
could you please explain why the version of controller-runtime will have to be updated here as well? And also, do you mean that it would have to be updated in controller-operator? I thought this only influenced the project developer convenience tooling connected with Tilt. If it isn't the case, I think it might be better to introduce |
Hi @azych IHMO: We can move forward with this one. 👍 🥇 The hassle is that if we upgrade the operator-controller and other projects, it would be better if we bump the next controller-runtime release with go 1.23 first then we can do it all. |
@camilamacedo86 |
When using tilt to run operator-controller / catalogd and having latest stable version of go (1.23.4), both controllers end up in a failed state because of the incompatible version of delve defined in tilt-support/Tiltfile builder:
This PR bumps the builder go version to 1.23 which is also used for dlv installation version and does not have compatibility issue.
An alternative solution could be to separate GO_VERSION and DLV_VERSION if the builder go version should not be updated for some reason (I did not found one).