Skip to content

allow working with mixed lists (ul/ol/todo) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

brunopagno
Copy link
Contributor

Ticket

https://community.openproject.org/projects/communicator-stream/work_packages/63309/activity

Counterpart of opf/openproject#19377

What are you trying to accomplish?

Fix an issue where data could be lost if unordered lists and todo lists were mixed together

What approach did you choose and why?

Adjusted the custom handling of LI items on the commonmark-ckeditor-build

Merge checklist

  • Added/updated tests
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@brunopagno brunopagno self-assigned this Jul 1, 2025
@brunopagno brunopagno requested review from a team and as-op July 1, 2025 15:13
@brunopagno brunopagno marked this pull request as draft July 3, 2025 08:44
@brunopagno brunopagno force-pushed the fix/63309-mixing-list-types branch 2 times, most recently from 1edb75a to 1ba2d9f Compare July 3, 2025 13:56
@brunopagno brunopagno force-pushed the fix/63309-mixing-list-types branch from 1ba2d9f to bfc2cc3 Compare July 3, 2025 14:03
@brunopagno brunopagno marked this pull request as ready for review July 3, 2025 14:10
Copy link
Contributor

@as-op as-op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Works as expected.

Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@brunopagno brunopagno merged commit 6426b8f into master Jul 7, 2025
3 checks passed
@brunopagno brunopagno deleted the fix/63309-mixing-list-types branch July 7, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants